( )⚙ D895 check-code: allow an exception for camelcase where required

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D895

check-code: allow an exception for camelcase where required
ClosedPublic

Authored by sid0 on Oct 2 2017, 5:35 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGb332c01247d8: check-code: allow an exception for camelcase where required
Summary

unittest has a maxDiff parameter which has to be set to None in order for
large enough failure diffs to be displayed. Add a comment to disable the
camelcase check for self.maxDiff = None lines.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sid0 created this revision.Oct 2 2017, 5:35 AM
indygreg accepted this revision.Oct 2 2017, 6:26 AM
This revision is now accepted and ready to land.Oct 2 2017, 6:26 AM
Closed by commit rHGb332c01247d8: check-code: allow an exception for camelcase where required (authored by sid0). · Explain WhyOct 2 2017, 1:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2337

contrib/check-code.py

r'(?P=indent)pass[ \t\n#]' r'(?P=indent)pass[ \t\n#]'
), 'omit superfluous pass'), ), 'omit superfluous pass'),
(r'.{81}', "line too long"), (r'.{81}', "line too long"),
(r'[^\n]\Z', "no trailing newline"), (r'[^\n]\Z', "no trailing newline"),
(r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"), (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
# (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=', # (r'^\s+[^_ \n][^_. \n]+_[^_\n]+\s*=',
# "don't use underbars in identifiers"), # "don't use underbars in identifiers"),
(r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ', (r'^\s+(self\.)?[A-Za-z][a-z0-9]+[A-Z]\w* = ',
"don't use camelcase in identifiers"), "don't use camelcase in identifiers", r'#.*camelcase-required'),
(r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+', (r'^\s*(if|while|def|class|except|try)\s[^[\n]*:\s*[^\\n]#\s]+',
"linebreak after :"), "linebreak after :"),
(r'class\s[^( \n]+:', "old-style class, use class foo(object)", (r'class\s[^( \n]+:', "old-style class, use class foo(object)",
r'#.*old-style'), r'#.*old-style'),
(r'class\s[^( \n]+\(\):', (r'class\s[^( \n]+\(\):',
"class foo() creates old style object, use class foo(object)", "class foo() creates old style object, use class foo(object)",
r'#.*old-style'), r'#.*old-style'),
(r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist (r'\b(%s)\(' % '|'.join(k for k in keyword.kwlist