Page MenuHomePhabricator

histedit: cache description line
ClosedPublic

Authored by martinvonz on Fri, Sep 11, 12:48 PM.

Details

Summary

Navigating the curses-based histedit interface can be pretty slow
because it redraws everything whenever you make a change.

This patch simply replaces @property by @util.propertycache on the
histeditrule.desc() function so it's not re-calculated every time
the screen needs to be re-rendered. I timed it on an example of 30
simple commits, where I moved the top commit down 25 steps and then up
25 steps after. Before this patch, that (the whole hg histedit
invocation) took 11.6 s of CPU and after this patch it took 0.8 s).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Fri, Sep 11, 12:48 PM
marmoute accepted this revision.Fri, Sep 11, 5:05 PM
marmoute added a subscriber: marmoute.

great

pulkit accepted this revision.Mon, Sep 14, 3:08 AM
This revision is now accepted and ready to land.Mon, Sep 14, 3:08 AM
This revision was automatically updated to reflect the committed changes.