This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9016

histedit: cache description line
ClosedPublic

Authored by martinvonz on Sep 11 2020, 12:48 PM.

Details

Reviewers
durin42
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHG47d10ade5bc4: histedit: cache description line
Summary

Navigating the curses-based histedit interface can be pretty slow
because it redraws everything whenever you make a change.

This patch simply replaces @property by @util.propertycache on the
histeditrule.desc() function so it's not re-calculated every time
the screen needs to be re-rendered. I timed it on an example of 30
simple commits, where I moved the top commit down 25 steps and then up
25 steps after. Before this patch, that (the whole hg histedit
invocation) took 11.6 s of CPU and after this patch it took 0.8 s).

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Sep 11 2020, 12:48 PM
marmoute accepted this revision.Sep 11 2020, 5:05 PM
marmoute added a subscriber: marmoute.

great

pulkit accepted this revision.Sep 14 2020, 3:08 AM
This revision is now accepted and ready to land.Sep 14 2020, 3:08 AM
martinvonz added a commit: rHG47d10ade5bc4: histedit: cache description line.Sep 14 2020, 4:04 AM
Closed by commit rHG47d10ade5bc4: histedit: cache description line (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/histedit.py (2 lines)

Diff 22626

hgext/histedit.py

return b"#%s %s %d:%s " % ( return b"#%s %s %d:%s " % (
(b'%d' % self.origpos).ljust(2), (b'%d' % self.origpos).ljust(2),
action.ljust(6), action.ljust(6),
r, r,
h, h,
) )
@property @util.propertycache
def desc(self): def desc(self):
summary = ( summary = (
cmdutil.rendertemplate( cmdutil.rendertemplate(
self.ctx, self.ui.config(b'histedit', b'summary-template') self.ctx, self.ui.config(b'histedit', b'summary-template')
) )
or b'' or b''
) )
if summary: if summary: