Page MenuHomePhabricator

packaging: normalize - to _ in WiX Id values
ClosedPublic

Authored by indygreg on Oct 5 2020, 1:39 AM.

Details

Summary
  • is not a valid identifier character in WiX Ids. So let's

normalize accordingly.

I discovered this issue after a subsequent change which introduces
a directory with a - in its name.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 5 2020, 1:39 AM
Alphare accepted this revision.Oct 5 2020, 4:38 AM
Alphare added a subscriber: Alphare.

Perhaps this would warrant a small utility function, but it's still small enough.

pulkit accepted this revision.Oct 6 2020, 4:32 AM
This revision is now accepted and ready to land.Oct 6 2020, 4:32 AM
This revision was automatically updated to reflect the committed changes.