( )⚙ D9267 crecord: render chunkpad on Windows (issue6427)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9267

crecord: render chunkpad on Windows (issue6427)
ClosedPublic

Authored by barret on Oct 31 2020, 5:49 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG91c41ea14598: crecord: render chunkpad on Windows (issue6427)
Summary

When using Windows wrappers of PDCurses (e.g., windows-curses), the chunkpad
does not render when executing hg commit -i. This is due to attempting to
refresh one too many columns of the pad.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

barret created this revision.Oct 31 2020, 5:49 PM
barret added a commit: rHG91c41ea14598: crecord: render chunkpad on Windows (issue6427).Nov 2 2020, 3:34 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG91c41ea14598: crecord: render chunkpad on Windows (issue6427) (authored by barret). · Explain Why
This revision was automatically updated to reflect the committed changes.
mharbison72 added a subscriber: mharbison72.Nov 26 2020, 1:05 AM

I didn't realize this was available on Windows. Is this stable enough that we could add it to the packaging, so that tweakdefaults is consistent across platforms? I just discovered the interface on Linux, and it is so much nicer than the default -i menu.

Revision Contents
Changeset List

PathPackages
Mmercurial/crecord.py (2 lines)

Diff 23391

mercurial/crecord.py

self.printitem() self.printitem()
self.updatescroll() self.updatescroll()
self.chunkpad.refresh( self.chunkpad.refresh(
self.firstlineofpadtoprint, self.firstlineofpadtoprint,
0, 0,
self.numstatuslines, self.numstatuslines,
0, 0,
self.yscreensize - self.numstatuslines, self.yscreensize - self.numstatuslines,
self.xscreensize, self.xscreensize - 1,
) )
except curses.error: except curses.error:
pass pass
def getstatusprefixstring(self, item): def getstatusprefixstring(self, item):
""" """
create a string to prefix a line with which indicates whether 'item' create a string to prefix a line with which indicates whether 'item'
is applied and/or folded. is applied and/or folded.