errors: remove trailing "!" from some error messages for consistency
ClosedPublic
Actions

Authored by martinvonz on Nov 23 2020, 6:30 PM.

Details

Reviewers

durin42
Alphare
mharbison72

Group Reviewers

hg-reviewers

Commits

rHG95c4cca641f6: errors: remove trailing "!" from some error messages for consistency

Summary

Some types of exceptions had a trailing "!" printed after the message
from the exception itself. I guess some of these errors seem a little
more severe (?), but it seems more likely that the inconsistency was
just an oversight.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 23 2020, 6:30 PM

Herald added a reviewer: durin42. · View Herald TranscriptNov 23 2020, 6:30 PM

Herald added a reviewer: hg-reviewers. · View Herald Transcript

Herald added a subscriber: mercurial-patches. · View Herald Transcript

martinvonz added a child revision: D9379: errors: consistently don't use trailing "!" in "not found in manifest" message.Nov 23 2020, 6:30 PM

Alphare accepted this revision.Nov 24 2020, 5:56 AM

mharbison72 accepted this revision.Nov 25 2020, 1:11 AM

mharbison72 added a subscriber: mharbison72.

mharbison72 added inline comments.

tests/test-convert-filemap.t
294–296	Fixed the dropped conditional, and the test case that wasn't run. There were a couple other cases like this (and I'm guessing a few stragglers in tests that weren't run). Rather than find them and mark them, I'm just going to push this because I think phab generates one last diff when pushed, and then the interdiff should reveal the others.

This revision is now accepted and ready to land.Nov 25 2020, 1:11 AM

martinvonz added a commit: rHG95c4cca641f6: errors: remove trailing "!" from some error messages for consistency.Nov 25 2020, 1:36 AM

Closed by commit rHG95c4cca641f6: errors: remove trailing "!" from some error messages for consistency (authored by martinvonz). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/scmutil.py (8 lines)
M			tests/test-alias.t (10 lines)
M			tests/test-bheads.t (2 lines)
M			tests/test-bookmarks-current.t (2 lines)
M			tests/test-bookmarks-pushpull.t (2 lines)
M			tests/test-bookmarks.t (12 lines)
M			tests/test-branch-change.t (2 lines)
M			tests/test-branch-option.t (4 lines)
M			tests/test-bundle-r.t (4 lines)
M			tests/test-bundle.t (6 lines)
M			tests/test-clone.t (14 lines)
M			tests/test-commandserver.t (6 lines)
M			tests/test-commit.t (2 lines)
M			tests/test-committer.t (2 lines)
M			tests/test-convert-filemap.t (4 lines)
M			tests/test-default-push.t (2 lines)
M			tests/test-directaccess.t (8 lines)
M			tests/test-dispatch.t (16 lines)
M			tests/test-export.t (2 lines)
M			tests/test-flagprocessor.t (2 lines)
M			tests/test-globalopts.t (4 lines)
M			tests/test-glog-beautifygraph.t (6 lines)
M			tests/test-glog.t (6 lines)
M			tests/test-grep.t (2 lines)
M			tests/test-hook.t (4 lines)
M			tests/test-http-bad-server.t (4 lines)
M			tests/test-i18n.t (6 lines)
M			tests/test-identify.t (6 lines)
M			tests/test-infinitepush-ci.t (4 lines)
M			tests/test-init.t (14 lines)
M			tests/test-journal-exists.t (6 lines)
M			tests/test-largefiles-misc.t (8 lines)
M			tests/test-largefiles.t (2 lines)
M			tests/test-legacy-exit-code.t (2 lines)
M			tests/test-lfconvert.t (6 lines)
M			tests/test-lfs-serve-access.t (24 lines)
M			tests/test-lfs-serve.t (4 lines)
M			tests/test-lfs-test-server.t (6 lines)
M			tests/test-lfs.t (6 lines)
M			tests/test-log.t (14 lines)
M			tests/test-logexchange.t (6 lines)
M			tests/test-manifest.t (2 lines)
M			tests/test-mq-qdelete.t (2 lines)
M			tests/test-mq-qrefresh.t (4 lines)
M			tests/test-mq.t (4 lines)
M			tests/test-narrow-clone.t (2 lines)
M			tests/test-narrow-exchange.t (6 lines)
M			tests/test-obshistory.t (16 lines)
M			tests/test-obsolete-distributed.t (2 lines)
M			tests/test-obsolete.t (6 lines)
M			tests/test-patchbomb.t (2 lines)
M			tests/test-pull-bundle.t (2 lines)
M			tests/test-pull-r.t (2 lines)
M			tests/test-pull.t (10 lines)
M			tests/test-push.t (4 lines)
M			tests/test-rebase-dest.t (2 lines)
M			tests/test-remotefilelog-repack.t (2 lines)
M			tests/test-repo-compengines.t (2 lines)
M			tests/test-requires.t (8 lines)
M			tests/test-revisions.t (2 lines)
M			tests/test-revlog-v2.t (4 lines)
M			tests/test-revlog.t (6 lines)
M			tests/test-revset-legacy-lookup.t (8 lines)
M			tests/test-revset-outgoing.t (4 lines)
M			tests/test-revset.t (24 lines)
M			tests/test-revset2.t (22 lines)
M			tests/test-share.t (4 lines)
M			tests/test-sparse-requirement.t (2 lines)
M			tests/test-ssh-bundle1.t (20 lines)
M			tests/test-ssh-proto.t (2 lines)
M			tests/test-ssh-repoerror.t (10 lines)
M			tests/test-ssh.t (32 lines)
M			tests/test-static-http.t (4 lines)
M			tests/test-strip.t (10 lines)
M			tests/test-subrepo-recursion.t (2 lines)
M			tests/test-subrepo.t (6 lines)
M			tests/test-template-functions.t (4 lines)
M			tests/test-treediscovery-legacy.t (4 lines)
M			tests/test-update-branches.t (2 lines)
M			tests/test-username-newline.t (2 lines)
M			tests/test-wireproto-caching.t (2 lines)
M			tests/test-wireproto-command-changesetdata.t (18 lines)
M			tests/test-wireproto-command-filedata.t (6 lines)
M			tests/test-wireproto-command-filesdata.t (6 lines)
M			tests/test-wireproto-command-manifestdata.t (6 lines)
M			tests/test-wireproto-command-rawstorefiledata.t (4 lines)

Status	Author	Revision
Closed	martinvonz	D9385 errors: raise InputError on bad bookmark argument
Closed	martinvonz	D9384 errors: raise ConfigError on bad alias definition
Closed	martinvonz	D9383 errors: raise InputError on bad repo arguments
Closed	martinvonz	D9382 errors: drop trailing "!" for some errors about bookmarks
Closed	martinvonz	D9381 errors: remove trailing "!" in messages about bad top-level args
Closed	martinvonz	D9380 errors: remove trailing "!" in messages about creating new heads on push
Closed	martinvonz	D9379 errors: consistently don't use trailing "!" in "not found in manifest" message
Closed	martinvonz	D9378 errors: remove trailing "!" from some error messages for consistency