This is an archive of the discontinued Mercurial Phabricator instance.

rhg: use `format_bytes!` for error messages
ClosedPublic

Authored by Alphare on Nov 26 2020, 5:48 AM.

Details

Summary

This change also includes a formatting changing with the new rustfmt version,
but I'm expecting it to have already been applied in another patch by the time
this lands.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Nov 26 2020, 5:48 AM
marmoute accepted this revision.Nov 26 2020, 8:34 AM
marmoute added a subscriber: marmoute.

Look much neater. If you can fix the unrelated change that would be great.

rust/hg-core/src/dirstate/dirstate_tree/node.rs
96–100 ↗(On Diff #23689)

This looks like an unrelated change. Chan you check your rust-format version ?

Look much neater. If you can fix the unrelated change that would be great.

I've mentioned this in the commit message. I'm thinking too much in terms of changesets, not patches. Should I drop it from this patch ?

marmoute requested changes to this revision.Nov 26 2020, 8:51 AM

Look much neater. If you can fix the unrelated change that would be great.

I've mentioned this in the commit message. I'm thinking too much in terms of changesets, not patches. Should I drop it from this patch ?

Yep, you should eitehr drop it or apply it in a different changesets. Especially because the patch that got in is pinning the formatting to the older version. So you new formatting is going to be wrong.

This revision now requires changes to proceed.Nov 26 2020, 8:51 AM
Alphare marked an inline comment as done.Nov 26 2020, 10:12 AM
Alphare updated this revision to Diff 23703.
pulkit accepted this revision.Nov 27 2020, 5:21 AM
pulkit requested changes to this revision.Nov 29 2020, 1:09 PM

This patch fails to apply on current tip of default branch. Kindly rebase and resend.

This revision now requires changes to proceed.Nov 29 2020, 1:09 PM
Alphare updated this revision to Diff 23881.Nov 30 2020, 11:01 AM
pulkit accepted this revision.Nov 30 2020, 11:32 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.