This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9434

tests: add a comment that we're purposely testing py2 extension attributes
ClosedPublic

Authored by mharbison72 on Nov 27 2020, 11:48 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG250e18437e30: tests: add a comment that we're purposely testing py2 extension attributes
Summary

Avoid someone unknowingly removing test coverage. There are tests for a
properly byteified testedwith a few lines down. I don't see similar for
buglink, but it's a trivial conversion to bytes, so I'm not concerned about
testing the expected/wanted extension state.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mtests/test-extension.t (6 lines)

Diff 23771

tests/test-extension.t

** Unknown exception encountered with possibly-broken third-party extension throw ** Unknown exception encountered with possibly-broken third-party extension throw
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable throw and try your action again. ** Please disable throw and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM * (glob) ** Mercurial Distributed SCM * (glob)
** Extensions loaded: throw ** Extensions loaded: throw
empty declaration of supported version, extension complains: empty declaration of supported version, extension complains (but doesn't choke if
the value is improperly a str instead of bytes):
$ echo "testedwith = ''" >> throw.py $ echo "testedwith = ''" >> throw.py
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension throw ** Unknown exception encountered with possibly-broken third-party extension throw
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable throw and try your action again. ** Please disable throw and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw ** Extensions loaded: throw
If the extension specifies a buglink, show that: If the extension specifies a buglink, show that (but don't choke if the value is
improperly a str instead of bytes):
$ echo 'buglink = "http://example.com/bts"' >> throw.py $ echo 'buglink = "http://example.com/bts"' >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension throw ** Unknown exception encountered with possibly-broken third-party extension throw
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable throw and try your action again. ** Please disable throw and try your action again.
** If that fixes the bug please report it to http://example.com/bts ** If that fixes the bug please report it to http://example.com/bts