This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9438

dispatch: quote the extension when printing the bug report
ClosedPublic

Authored by mharbison72 on Nov 27 2020, 11:48 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa2104b9b1787: dispatch: quote the extension when printing the bug report
Summary

I think this reads better in the wall of text.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

Diff 23774

mercurial/dispatch.py

name, testedwith, report, version = worst name, testedwith, report, version = worst
if not isinstance(testedwith, (bytes, str)): if not isinstance(testedwith, (bytes, str)):
testedwith = b'.'.join( testedwith = b'.'.join(
[stringutil.forcebytestr(c) for c in testedwith] [stringutil.forcebytestr(c) for c in testedwith]
) )
extver = version or _(b"(version N/A)") extver = version or _(b"(version N/A)")
warning = _( warning = _(
b'** Unknown exception encountered with ' b'** Unknown exception encountered with '
b'possibly-broken third-party extension %s %s\n' b'possibly-broken third-party extension "%s" %s\n'
b'** which supports versions %s of Mercurial.\n' b'** which supports versions %s of Mercurial.\n'
b'** Please disable %s and try your action again.\n' b'** Please disable "%s" and try your action again.\n'
b'** If that fixes the bug please report it to %s\n' b'** If that fixes the bug please report it to %s\n'
) % (name, extver, testedwith, name, stringutil.forcebytestr(report)) ) % (name, extver, testedwith, name, stringutil.forcebytestr(report))
else: else:
bugtracker = ui.config(b'ui', b'supportcontact') bugtracker = ui.config(b'ui', b'supportcontact')
if bugtracker is None: if bugtracker is None:
bugtracker = _(b"https://mercurial-scm.org/wiki/BugTracker") bugtracker = _(b"https://mercurial-scm.org/wiki/BugTracker")
warning = ( warning = (
_( _(

tests/test-blackbox.t

[255] [255]
#else #else
(hg exits 1 because Python default exit code for uncaught exception is 1) (hg exits 1 because Python default exit code for uncaught exception is 1)
$ hg raise 2>/dev/null $ hg raise 2>/dev/null
[1] [1]
#endif #endif
$ head -1 .hg/blackbox.log $ head -1 .hg/blackbox.log
1970/01/01 00:00:00 bob @0000000000000000000000000000000000000000 (5000)> ** Unknown exception encountered with possibly-broken third-party extension mock (version N/A) 1970/01/01 00:00:00 bob @0000000000000000000000000000000000000000 (5000)> ** Unknown exception encountered with possibly-broken third-party extension "mock" (version N/A)
$ tail -2 .hg/blackbox.log $ tail -2 .hg/blackbox.log
RuntimeError: raise RuntimeError: raise

tests/test-devel-warnings.t

$TESTTMP/buggylocking.py:* in oldanddeprecated (glob) $TESTTMP/buggylocking.py:* in oldanddeprecated (glob)
1970/01/01 00:00:00 bob @cb9a9f314b8b07ba71012fcdbc544b5a4d82ff5b (5000)> oldanddeprecated --traceback exited 0 after * seconds (glob) 1970/01/01 00:00:00 bob @cb9a9f314b8b07ba71012fcdbc544b5a4d82ff5b (5000)> oldanddeprecated --traceback exited 0 after * seconds (glob)
1970/01/01 00:00:00 bob @cb9a9f314b8b07ba71012fcdbc544b5a4d82ff5b (5000)> blackbox -l 7 1970/01/01 00:00:00 bob @cb9a9f314b8b07ba71012fcdbc544b5a4d82ff5b (5000)> blackbox -l 7
#endif #endif
Test programming error failure: Test programming error failure:
$ hg buggytransaction 2>&1 | egrep -v '^ ' $ hg buggytransaction 2>&1 | egrep -v '^ '
** Unknown exception encountered with possibly-broken third-party extension buggylocking (version N/A) ** Unknown exception encountered with possibly-broken third-party extension "buggylocking" (version N/A)
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable buggylocking and try your action again. ** Please disable "buggylocking" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: * (glob) ** Extensions loaded: * (glob)
** ProgrammingError: transaction requires locking ** ProgrammingError: transaction requires locking
Traceback (most recent call last): Traceback (most recent call last):
*ProgrammingError: transaction requires locking (glob) *ProgrammingError: transaction requires locking (glob)
$ hg programmingerror 2>&1 | egrep -v '^ ' $ hg programmingerror 2>&1 | egrep -v '^ '
** Unknown exception encountered with possibly-broken third-party extension buggylocking (version N/A) ** Unknown exception encountered with possibly-broken third-party extension "buggylocking" (version N/A)
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable buggylocking and try your action again. ** Please disable "buggylocking" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: * (glob) ** Extensions loaded: * (glob)
** ProgrammingError: something went wrong ** ProgrammingError: something went wrong
** (try again) ** (try again)
Traceback (most recent call last): Traceback (most recent call last):
*ProgrammingError: something went wrong (glob) *ProgrammingError: something went wrong (glob)

tests/test-extension.t

Test extension without proper byteification of key attributes doesn't crash when Test extension without proper byteification of key attributes doesn't crash when
accessed. accessed.
$ hg version -v --config extensions.throw=throw.py | grep '^ ' $ hg version -v --config extensions.throw=throw.py | grep '^ '
throw external 1.0.0 throw external 1.0.0
No declared supported version, extension complains: No declared supported version, extension complains:
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension throw 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable throw and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM * (glob) ** Mercurial Distributed SCM * (glob)
** Extensions loaded: throw ** Extensions loaded: throw
empty declaration of supported version, extension complains (but doesn't choke if empty declaration of supported version, extension complains (but doesn't choke if
the value is improperly a str instead of bytes): the value is improperly a str instead of bytes):
$ echo "testedwith = ''" >> throw.py $ echo "testedwith = ''" >> throw.py
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension throw 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable throw and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw ** Extensions loaded: throw
If the extension specifies a buglink, show that (but don't choke if the value is If the extension specifies a buglink, show that (but don't choke if the value is
improperly a str instead of bytes): improperly a str instead of bytes):
$ echo 'buglink = "http://example.com/bts"' >> throw.py $ echo 'buglink = "http://example.com/bts"' >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension throw 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable throw and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to http://example.com/bts ** If that fixes the bug please report it to http://example.com/bts
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw ** Extensions loaded: throw
If the extensions declare outdated versions, accuse the older extension first: If the extensions declare outdated versions, accuse the older extension first:
$ echo "from mercurial import util" >> older.py $ echo "from mercurial import util" >> older.py
$ echo "util.version = lambda:b'2.2'" >> older.py $ echo "util.version = lambda:b'2.2'" >> older.py
$ echo "testedwith = b'1.9.3'" >> older.py $ echo "testedwith = b'1.9.3'" >> older.py
$ echo "testedwith = b'2.1.1'" >> throw.py $ echo "testedwith = b'2.1.1'" >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension older (version N/A) ** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A)
** which supports versions 1.9 of Mercurial. ** which supports versions 1.9 of Mercurial.
** Please disable older and try your action again. ** Please disable "older" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 2.2) ** Mercurial Distributed SCM (version 2.2)
** Extensions loaded: throw, older ** Extensions loaded: throw, older
One extension only tested with older, one only with newer versions: One extension only tested with older, one only with newer versions:
$ echo "util.version = lambda:b'2.1'" >> older.py $ echo "util.version = lambda:b'2.1'" >> older.py
$ rm -f older.pyc older.pyo $ rm -f older.pyc older.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension older (version N/A) ** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A)
** which supports versions 1.9 of Mercurial. ** which supports versions 1.9 of Mercurial.
** Please disable older and try your action again. ** Please disable "older" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 2.1) ** Mercurial Distributed SCM (version 2.1)
** Extensions loaded: throw, older ** Extensions loaded: throw, older
Older extension is tested with current version, the other only with newer: Older extension is tested with current version, the other only with newer:
$ echo "util.version = lambda:b'1.9.3'" >> older.py $ echo "util.version = lambda:b'1.9.3'" >> older.py
$ rm -f older.pyc older.pyo $ rm -f older.pyc older.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension throw 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions 2.1 of Mercurial. ** which supports versions 2.1 of Mercurial.
** Please disable throw and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to http://example.com/bts ** If that fixes the bug please report it to http://example.com/bts
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 1.9.3) ** Mercurial Distributed SCM (version 1.9.3)
** Extensions loaded: throw, older ** Extensions loaded: throw, older
Ability to point to a different point Ability to point to a different point
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> --config ui.supportcontact='Your Local Goat Lenders' throw 2>&1 | egrep '^\*\*' > --config ui.supportcontact='Your Local Goat Lenders' throw 2>&1 | egrep '^\*\*'