This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9440

dispatch: print the version of each extension in the bug report, if available
ClosedPublic

Authored by mharbison72 on Nov 27 2020, 11:49 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa120d1c9c704: dispatch: print the version of each extension in the bug report, if available
Summary

Sometimes the wrong extensions is blamed, so we might as well print the version
info for all of them. Additionally, since the internal extensions are never
blamed, this is a good way to make the pygit2 version available in a bug report.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/dispatch.py (12 lines)
Mtests/test-extension.t (18 lines)

Diff 23776

mercurial/dispatch.py

_( _(
b"** unknown exception encountered, " b"** unknown exception encountered, "
b"please report by visiting\n** " b"please report by visiting\n** "
) )
+ bugtracker + bugtracker
+ b'\n' + b'\n'
) )
sysversion = pycompat.sysbytes(sys.version).replace(b'\n', b'') sysversion = pycompat.sysbytes(sys.version).replace(b'\n', b'')
def ext_with_ver(x):
ext = x[0]
ver = extensions.moduleversion(x[1])
if ver:
ext += b' ' + ver
return ext
warning += ( warning += (
(_(b"** Python %s\n") % sysversion) (_(b"** Python %s\n") % sysversion)
+ (_(b"** Mercurial Distributed SCM (version %s)\n") % util.version()) + (_(b"** Mercurial Distributed SCM (version %s)\n") % util.version())
+ ( + (
_(b"** Extensions loaded: %s\n") _(b"** Extensions loaded: %s\n")
% b", ".join([x[0] for x in sorted(extensions.extensions())]) % b", ".join(
[ext_with_ver(x) for x in sorted(extensions.extensions())]
)
) )
) )
return warning return warning
def handlecommandexception(ui): def handlecommandexception(ui):
"""Produce a warning message for broken commands """Produce a warning message for broken commands

tests/test-extension.t

No declared supported version, extension complains: No declared supported version, extension complains:
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable "throw" and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM * (glob) ** Mercurial Distributed SCM * (glob)
** Extensions loaded: throw ** Extensions loaded: throw 1.0.0
empty declaration of supported version, extension complains (but doesn't choke if empty declaration of supported version, extension complains (but doesn't choke if
the value is improperly a str instead of bytes): the value is improperly a str instead of bytes):
$ echo "testedwith = ''" >> throw.py $ echo "testedwith = ''" >> throw.py
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable "throw" and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw ** Extensions loaded: throw 1.0.0
If the extension specifies a buglink, show that (but don't choke if the value is If the extension specifies a buglink, show that (but don't choke if the value is
improperly a str instead of bytes): improperly a str instead of bytes):
$ echo 'buglink = "http://example.com/bts"' >> throw.py $ echo 'buglink = "http://example.com/bts"' >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions unknown of Mercurial. ** which supports versions unknown of Mercurial.
** Please disable "throw" and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to http://example.com/bts ** If that fixes the bug please report it to http://example.com/bts
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw ** Extensions loaded: throw 1.0.0
If the extensions declare outdated versions, accuse the older extension first: If the extensions declare outdated versions, accuse the older extension first:
$ echo "from mercurial import util" >> older.py $ echo "from mercurial import util" >> older.py
$ echo "util.version = lambda:b'2.2'" >> older.py $ echo "util.version = lambda:b'2.2'" >> older.py
$ echo "testedwith = b'1.9.3'" >> older.py $ echo "testedwith = b'1.9.3'" >> older.py
$ echo "testedwith = b'2.1.1'" >> throw.py $ echo "testedwith = b'2.1.1'" >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A) ** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A)
** which supports versions 1.9 of Mercurial. ** which supports versions 1.9 of Mercurial.
** Please disable "older" and try your action again. ** Please disable "older" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 2.2) ** Mercurial Distributed SCM (version 2.2)
** Extensions loaded: older, throw ** Extensions loaded: older, throw 1.0.0
One extension only tested with older, one only with newer versions: One extension only tested with older, one only with newer versions:
$ echo "util.version = lambda:b'2.1'" >> older.py $ echo "util.version = lambda:b'2.1'" >> older.py
$ rm -f older.pyc older.pyo $ rm -f older.pyc older.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A) ** Unknown exception encountered with possibly-broken third-party extension "older" (version N/A)
** which supports versions 1.9 of Mercurial. ** which supports versions 1.9 of Mercurial.
** Please disable "older" and try your action again. ** Please disable "older" and try your action again.
** If that fixes the bug please report it to the extension author. ** If that fixes the bug please report it to the extension author.
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 2.1) ** Mercurial Distributed SCM (version 2.1)
** Extensions loaded: older, throw ** Extensions loaded: older, throw 1.0.0
Older extension is tested with current version, the other only with newer: Older extension is tested with current version, the other only with newer:
$ echo "util.version = lambda:b'1.9.3'" >> older.py $ echo "util.version = lambda:b'1.9.3'" >> older.py
$ rm -f older.pyc older.pyo $ rm -f older.pyc older.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> throw 2>&1 | egrep '^\*\*' > throw 2>&1 | egrep '^\*\*'
** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0 ** Unknown exception encountered with possibly-broken third-party extension "throw" 1.0.0
** which supports versions 2.1 of Mercurial. ** which supports versions 2.1 of Mercurial.
** Please disable "throw" and try your action again. ** Please disable "throw" and try your action again.
** If that fixes the bug please report it to http://example.com/bts ** If that fixes the bug please report it to http://example.com/bts
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (version 1.9.3) ** Mercurial Distributed SCM (version 1.9.3)
** Extensions loaded: older, throw ** Extensions loaded: older, throw 1.0.0
Ability to point to a different point Ability to point to a different point
$ hg --config extensions.throw=throw.py --config extensions.older=older.py \ $ hg --config extensions.throw=throw.py --config extensions.older=older.py \
> --config ui.supportcontact='Your Local Goat Lenders' throw 2>&1 | egrep '^\*\*' > --config ui.supportcontact='Your Local Goat Lenders' throw 2>&1 | egrep '^\*\*'
** unknown exception encountered, please report by visiting ** unknown exception encountered, please report by visiting
** Your Local Goat Lenders ** Your Local Goat Lenders
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: older, throw ** Extensions loaded: older, throw 1.0.0
Declare the version as supporting this hg version, show regular bts link: Declare the version as supporting this hg version, show regular bts link:
$ hgver=`hg debuginstall -T '{hgver}'` $ hgver=`hg debuginstall -T '{hgver}'`
$ echo 'testedwith = """'"$hgver"'"""' >> throw.py $ echo 'testedwith = """'"$hgver"'"""' >> throw.py
$ if [ -z "$hgver" ]; then $ if [ -z "$hgver" ]; then
> echo "unable to fetch a mercurial version. Make sure __version__ is correct"; > echo "unable to fetch a mercurial version. Make sure __version__ is correct";
> fi > fi
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** unknown exception encountered, please report by visiting ** unknown exception encountered, please report by visiting
** https://mercurial-scm.org/wiki/BugTracker ** https://mercurial-scm.org/wiki/BugTracker
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw ** Extensions loaded: throw 1.0.0
Patch version is ignored during compatibility check Patch version is ignored during compatibility check
$ echo "testedwith = b'3.2'" >> throw.py $ echo "testedwith = b'3.2'" >> throw.py
$ echo "util.version = lambda:b'3.2.2'" >> throw.py $ echo "util.version = lambda:b'3.2.2'" >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*' $ hg --config extensions.throw=throw.py throw 2>&1 | egrep '^\*\*'
** unknown exception encountered, please report by visiting ** unknown exception encountered, please report by visiting
** https://mercurial-scm.org/wiki/BugTracker ** https://mercurial-scm.org/wiki/BugTracker
** Python * (glob) ** Python * (glob)
** Mercurial Distributed SCM (*) (glob) ** Mercurial Distributed SCM (*) (glob)
** Extensions loaded: throw ** Extensions loaded: throw 1.0.0
Test version number support in 'hg version': Test version number support in 'hg version':
$ echo '__version__ = (1, 2, 3)' >> throw.py $ echo '__version__ = (1, 2, 3)' >> throw.py
$ rm -f throw.pyc throw.pyo $ rm -f throw.pyc throw.pyo
$ rm -Rf __pycache__ $ rm -Rf __pycache__
$ hg version -v $ hg version -v
Mercurial Distributed SCM (version *) (glob) Mercurial Distributed SCM (version *) (glob)
(see https://mercurial-scm.org for more information) (see https://mercurial-scm.org for more information)