This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9515

command: automatically create alias for command using '-' in names
ClosedPublic

Authored by marmoute on Dec 4 2020, 4:25 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Commits
rHG012e25abc603: command: automatically create alias for command using '-' in names
Summary

As discussed during the "5.6 Sprint" ignoring dash in command name open the way
to using them more. We can now move existing command to more readable (dash
using) names without breaking any compatibility.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 4 2020, 4:25 AM
pulkit accepted this revision.Dec 4 2020, 2:18 PM
pulkit added a subscriber: pulkit.

Looks good to me but since I was not there in that sprint discussion, I will let someone else queue it.

mercurial/cmdutil.py
361

Since the logic is growing, some function documentation will be great!

This revision is now accepted and ready to land.Dec 4 2020, 2:18 PM
Alphare accepted this revision.Dec 14 2020, 5:00 AM
Alphare added a subscriber: Alphare.

Same remark as Pulkit, looks good to me otherwise.

baymax updated this revision to Diff 24512.Dec 27 2020, 1:42 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a comment.Jan 7 2021, 6:17 PM

Anything I can do to get this pushed ?

Revision Contents
Changeset List

PathPackages
Mmercurial/cmdutil.py (12 lines)

Diff 24800

mercurial/cmdutil.py

): ):
newlyaddedandmodifiedfiles.add(chunk.header.filename()) newlyaddedandmodifiedfiles.add(chunk.header.filename())
alsorestore.update( alsorestore.update(
set(chunk.header.files()) - {chunk.header.filename()} set(chunk.header.files()) - {chunk.header.filename()}
) )
return newlyaddedandmodifiedfiles, alsorestore return newlyaddedandmodifiedfiles, alsorestore
def parsealiases(cmd): def parsealiases(cmd):
pulkitUnsubmitted
Not Done

Since the logic is growing, some function documentation will be great!

pulkit: Since the logic is growing, some function documentation will be great!
return cmd.split(b"|") base_aliases = cmd.split(b"|")
all_aliases = set(base_aliases)
extra_aliases = []
for alias in base_aliases:
if b'-' in alias:
folded_alias = alias.replace(b'-', b'')
if folded_alias not in all_aliases:
all_aliases.add(folded_alias)
extra_aliases.append(folded_alias)
base_aliases.extend(extra_aliases)
return base_aliases
def setupwrapcolorwrite(ui): def setupwrapcolorwrite(ui):
# wrap ui.write so diff output can be labeled/colorized # wrap ui.write so diff output can be labeled/colorized
def wrapwrite(orig, *args, **kw): def wrapwrite(orig, *args, **kw):
label = kw.pop('label', b'') label = kw.pop('label', b'')
for chunk, l in patch.difflabel(lambda: args): for chunk, l in patch.difflabel(lambda: args):
orig(chunk, label=label + l) orig(chunk, label=label + l)