Page MenuHomePhabricator

perf: use the `perf--` prefix for perf command
Needs ReviewPublic

Authored by marmoute on Dec 4 2020, 4:25 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Summary

This is the one command namespace where they should not be any ambiguity about
command that should be in it. The perf extensions is only adding performance
related command.

so this is a good ground to start putting dash folding to the tests.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Dec 4 2020, 4:25 AM
pulkit accepted this revision.Dec 4 2020, 2:19 PM
This revision is now accepted and ready to land.Dec 4 2020, 2:19 PM
baymax updated this revision to Diff 24070.Dec 6 2020, 9:37 AM
Alphare accepted this revision.Dec 14 2020, 5:01 AM
baymax retitled this revision from perf: use the `perf-` prefix for perf command to perf: use the `perf--` prefix for perf command.Sun, Dec 27, 1:42 PM
baymax updated this revision to Diff 24513.

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

durin42 added inline comments.
contrib/perf.py
747

Why is this two dashes and not one?

(Here and elsewhere. I was surprised to see two and not one, and I don't know what that signifies...)

marmoute requested review of this revision.Wed, Jan 13, 11:15 PM
marmoute added inline comments.
contrib/perf.py
747

I took a time machine and answer that question last month ;-)

https://www.mercurial-scm.org/pipermail/mercurial-devel/2020-December/144168.html