Page MenuHomePhabricator

debugsetparents: add various warning in the help message
ClosedPublic

Authored by marmoute on Dec 7 2020, 4:58 PM.

Details

Summary

I am tired to see people shooting themself in the foot with this. So lets add
more warning. At that point we should probably rename it or add extra
confirmation flag. This is a debug command anyway we can break BC on it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 7 2020, 4:58 PM

What do you think about disabling this command entirely by default via config (like we do with rollback), and blasting this text out if the config is not set? I fear most usage of this is cargoculting off of SO, so people aren't going to see this in the help.

pulkit added a subscriber: pulkit.Dec 8 2020, 2:08 AM

What do you think about disabling this command entirely by default via config (like we do with rollback), and blasting this text out if the config is not set? I fear most usage of this is cargoculting off of SO, so people aren't going to see this in the help.

+1 to what Matt said.

+1 for disabling this by default

Disabling the command and making it available through a config seems fine. Can we get the doc update anyways ? I'll follow up with the config (an update of the doc that point to the config).

pulkit accepted this revision.Sat, Jan 9, 5:09 AM

Disabling the command and making it available through a config seems fine. Can we get the doc update anyways ? I'll follow up with the config (an update of the doc that point to the config).

Adding to that, a good follow-up will be mentioning replacements that can be used.

This revision is now accepted and ready to land.Sat, Jan 9, 5:09 AM
This revision was automatically updated to reflect the committed changes.