Page MenuHomePhabricator

statichttprepo: explicitly convert error message to str (issue6247)
ClosedPublic

Authored by joerg.sonnenberger on Sun, Dec 27, 7:31 PM.

Details

Summary

For Python 2.7, the implicit conversion of the HTTPError instance to
str was good enough. For Python 3.x, this fails later when hitting the
str to bytes conversion logic.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

This is for BZ issue 6247.

marmoute accepted this revision.Fri, Jan 8, 11:12 AM
marmoute added a subscriber: marmoute.

maybe add a comment pointing the issue next to the str(…) call ?

marmoute accepted this revision.Fri, Jan 8, 3:57 PM
pulkit added a subscriber: pulkit.Sat, Jan 9, 5:02 AM

This is for BZ issue 6247.

For the bz bot to work, you will need to append (issueXXXX) to main commit description. https://www.mercurial-scm.org/wiki/ContributingChanges#Patch_descriptions

joerg.sonnenberger retitled this revision from statichttprepo: explicitly convert error message to str to statichttprepo: explicitly convert error message to str (issue6247).Sat, Jan 9, 5:15 AM
pulkit accepted this revision.Sat, Jan 9, 5:19 AM
This revision is now accepted and ready to land.Sat, Jan 9, 5:19 AM