This is an archive of the discontinued Mercurial Phabricator instance.

statichttprepo: explicitly convert error message to str (issue6247)
ClosedPublic

Authored by joerg.sonnenberger on Dec 27 2020, 7:31 PM.

Details

Summary

For Python 2.7, the implicit conversion of the HTTPError instance to
str was good enough. For Python 3.x, this fails later when hitting the
str to bytes conversion logic.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

This is for BZ issue 6247.

marmoute accepted this revision.Jan 8 2021, 11:12 AM
marmoute added a subscriber: marmoute.

maybe add a comment pointing the issue next to the str(…) call ?

marmoute accepted this revision.Jan 8 2021, 3:57 PM
pulkit added a subscriber: pulkit.Jan 9 2021, 5:02 AM

This is for BZ issue 6247.

For the bz bot to work, you will need to append (issueXXXX) to main commit description. https://www.mercurial-scm.org/wiki/ContributingChanges#Patch_descriptions

joerg.sonnenberger retitled this revision from statichttprepo: explicitly convert error message to str to statichttprepo: explicitly convert error message to str (issue6247).Jan 9 2021, 5:15 AM
pulkit accepted this revision.Jan 9 2021, 5:19 AM
This revision is now accepted and ready to land.Jan 9 2021, 5:19 AM