This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9737

shelve: use listdir() instead of readdir() when we don't need stat information
ClosedPublic

Authored by martinvonz on Jan 12 2021, 5:48 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGe33266b916be: shelve: use listdir() instead of readdir() when we don't need stat information
rHG851dfb4212fb: shelve: use listdir() instead of readdir() when we don't need stat information
rHG758eb5757d4c: shelve: use listdir() instead of readdir() when we don't need stat information

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/shelve.py (4 lines)

Diff 24740

mercurial/shelve.py

) )
shelf.movetobackup() shelf.movetobackup()
cleanupoldbackups(repo) cleanupoldbackups(repo)
def listshelves(repo): def listshelves(repo):
"""return all shelves in repo as list of (time, name)""" """return all shelves in repo as list of (time, name)"""
try: try:
names = repo.vfs.readdir(shelvedir) names = repo.vfs.listdir(shelvedir)
except OSError as err: except OSError as err:
if err.errno != errno.ENOENT: if err.errno != errno.ENOENT:
raise raise
return [] return []
info = [] info = []
seen = set() seen = set()
for (filename, _type) in names: for filename in names:
name = filename.rsplit(b'.', 1)[0] name = filename.rsplit(b'.', 1)[0]
if name in seen: if name in seen:
continue continue
seen.add(name) seen.add(name)
shelf = Shelf(repo, name) shelf = Shelf(repo, name)
if not shelf.exists(): if not shelf.exists():
continue continue
mtime = shelf.mtime() mtime = shelf.mtime()