This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	martinvonz	D9744 shelve: move listshelves() to new ShelfDir class, so caller need not pass vfs
Closed	martinvonz	D9743 shelve: also create class representing whole directory of shelves
Closed	martinvonz	D9742 shelve: add a method for deleting shelf to new shelf class
Closed	martinvonz	D9741 shelve: inline ".patch" constant now that it's only used in the Shelf class
Closed	martinvonz	D9740 shelve: use listshelves() in cleanupoldbackups()
Closed	martinvonz	D9739 shelve: make listshelves() list shelves in a given vfs
Closed	martinvonz	D9738 shelve: replace repo instance in Shelf class by vfs instance
Closed	martinvonz	D9737 shelve: use listdir() instead of readdir() when we don't need stat information
Closed	martinvonz	D9720 shelve: don't crash on file with unexpected extension in .hg/shelved/
Closed	martinvonz	D9719 shelve: don't include invalid shelves in `hg shelve --list`
Closed	martinvonz	D9714 shelve: extract some repeated creation of shelf instances to variables
Closed	martinvonz	D9713 shelve: teach new shelf class to check if .shelve file exists
Closed	martinvonz	D9712 shelve: move method for creating backup to new shelf class
Closed	martinvonz	D9711 shelve: make gennames() helper generate relative backup paths
Closed	martinvonz	D9710 shelve: use listshelves() in cleanup function
Closed	martinvonz	D9709 shelve: inline shelvedfile.filename() since there are no callers outside class
Closed	martinvonz	D9708 shelve: make listshelves() return shelf names instead of filenames
Closed	martinvonz	D9707 shelve: move method for getting stat (mtime) to new shelf class
Closed	martinvonz	D9706 shelve: open patch using new shelf class instead of open()
Closed	martinvonz	D9705 shelve: move function for opening .patch file to new shelf class
Closed	martinvonz	D9704 shelve: move method for reading .hg to new shelf class
Closed	martinvonz	D9703 shelve: move method for writing bundle to new shelf class
Closed	martinvonz	D9702 shelve: move method for reading .shelve file to new shelf class
Closed	martinvonz	D9701 shelve: move method for writing .shelve to new shelf class
Closed	martinvonz	D9700 shelve: introduce class representing a shelf
Closed	martinvonz	D9699 shelve: raise more specific errors
Closed	martinvonz	D9698 shelve: trust caller of shelvedfile.opener() to check that the file exists
Closed	martinvonz	D9697 shelve: rewrite check for unknown shelf to delete
Closed	martinvonz	D9696 shelve: remove a bundlerepo method
Closed	martinvonz	D9718 tests: add tests for corrupt .hg/shelved/ directory

Diff 24952

mercurial/shelve.py

	)			)
	shelf.movetobackup()			shelf.movetobackup()
	cleanupoldbackups(repo)			cleanupoldbackups(repo)


	def listshelves(repo):			def listshelves(repo):
	"""return all shelves in repo as list of (time, name)"""			"""return all shelves in repo as list of (time, name)"""
	try:			try:
	names = repo.vfs.readdir(shelvedir)			names = repo.vfs.listdir(shelvedir)
	except OSError as err:			except OSError as err:
	if err.errno != errno.ENOENT:			if err.errno != errno.ENOENT:
	raise			raise
	return []			return []
	info = []			info = []
	seen = set()			seen = set()
	for (filename, _type) in names:			for filename in names:
	name = filename.rsplit(b'.', 1)[0]			name = filename.rsplit(b'.', 1)[0]
	if name in seen:			if name in seen:
	continue			continue
	seen.add(name)			seen.add(name)
	shelf = Shelf(repo, name)			shelf = Shelf(repo, name)
	if not shelf.exists():			if not shelf.exists():
	continue			continue
	mtime = shelf.mtime()			mtime = shelf.mtime()

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	24740		Jan 12 2021, 5:48 PM	★	★
Diff 2	24952	rHG758eb5757d4c389f74f43b69c97fa587b6feb0b7	Jan 11 2021, 1:35 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

shelve: use listdir() instead of readdir() when we don't need stat informationClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24952

mercurial/shelve.py

shelve: use listdir() instead of readdir() when we don't need stat information
ClosedPublic

Revision Contents
Changeset List