This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9759

ui: add a "config_default" method
ClosedPublic

Authored by marmoute on Jan 13 2021, 11:05 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGb9b37418ac7e: ui: add a "config_default" method
Summary

This allow code to access the expected value for a config. This is useful in the
context of dynamic default value, and short term it will be useful to write
dynamically "correct" code.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 13 2021, 11:05 PM
Alphare accepted this revision.Jan 15 2021, 5:51 AM
Alphare added a subscriber: Alphare.

Interesting that it doesn't exist already!

baymax updated this revision to Diff 24891.Jan 15 2021, 6:59 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHGb9b37418ac7e: ui: add a "config_default" method.Jan 16 2021, 3:54 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGb9b37418ac7e: ui: add a "config_default" method (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (12 lines)

Diff 24829

mercurial/ui.py

uvalue = self._ucfg.get(s, n) uvalue = self._ucfg.get(s, n)
if uvalue is not None and uvalue != value: if uvalue is not None and uvalue != value:
self.debug( self.debug(
b"ignoring untrusted configuration option " b"ignoring untrusted configuration option "
b"%s.%s = %s\n" % (s, n, uvalue) b"%s.%s = %s\n" % (s, n, uvalue)
) )
return value return value
def config_default(self, section, name):
"""return the default value for a config option
The default is returned "raw", for example if it is a callable, the
callable was not called.
"""
item = self._knownconfig.get(section, {}).get(name)
if item is None:
raise KeyError((section, name))
return item.default
def configsuboptions(self, section, name, default=_unset, untrusted=False): def configsuboptions(self, section, name, default=_unset, untrusted=False):
"""Get a config option and all sub-options. """Get a config option and all sub-options.
Some config options have sub-options that are declared with the Some config options have sub-options that are declared with the
format "key:opt = value". This method is used to return the main format "key:opt = value". This method is used to return the main
option and all its declared sub-options. option and all its declared sub-options.
Returns a 2-tuple of ``(option, sub-options)``, where `sub-options`` Returns a 2-tuple of ``(option, sub-options)``, where `sub-options``