Page MenuHomePhabricator

hghave: adjust the definition of `tic` to allow curses tests on Windows
ClosedPublic

Authored by mharbison72 on Jan 17 2021, 2:52 AM.

Details

Summary

Might as well pick up the test coverage if it works as-is.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 17 2021, 2:52 AM
pulkit accepted this revision.Jan 17 2021, 11:43 AM
This revision is now accepted and ready to land.Jan 17 2021, 11:43 AM

Shouldn't this patch be checking for the existence of the windows_curses package instead?

Shouldn't this patch be checking for the existence of the windows_curses package instead?

I don't think so. The only files pip install windows_curses creates besides *.dist-info/ are _curses.pyd and _curses_panel.pyd. With these in place, I can import curses in a python REPL, but I can't import windows_curses. (On a related note, I probably need to fix the py2exe config to include this, because I'm seeing explicit includes are needed for the thg installer.)