This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9808

hghave: adjust the definition of `tic` to allow curses tests on Windows
ClosedPublic

Authored by mharbison72 on Jan 17 2021, 2:52 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGef771d329961: hghave: adjust the definition of `tic` to allow curses tests on Windows
Summary

Might as well pick up the test coverage if it works as-is.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Jan 17 2021, 2:52 AM
pulkit accepted this revision.Jan 17 2021, 11:43 AM
This revision is now accepted and ready to land.Jan 17 2021, 11:43 AM
indygreg added a subscriber: indygreg.Jan 24 2021, 3:32 PM

Shouldn't this patch be checking for the existence of the windows_curses package instead?

mharbison72 added a comment.Jan 24 2021, 3:57 PM
In D9808#149349, @indygreg wrote:

Shouldn't this patch be checking for the existence of the windows_curses package instead?

I don't think so. The only files pip install windows_curses creates besides *.dist-info/ are _curses.pyd and _curses_panel.pyd. With these in place, I can import curses in a python REPL, but I can't import windows_curses. (On a related note, I probably need to fix the py2exe config to include this, because I'm seeing explicit includes are needed for the thg installer.)

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (6 lines)

Diff 25079

tests/hghave.py

@check("tic", "terminfo compiler and curses module") @check("tic", "terminfo compiler and curses module")
def has_tic(): def has_tic():
try: try:
import curses import curses
curses.COLOR_BLUE curses.COLOR_BLUE
# Windows doesn't have a `tic` executable, but the windows_curses
# package is sufficient to run the tests without it.
if os.name == 'nt':
return True
return matchoutput('test -x "`which tic`"', br'') return matchoutput('test -x "`which tic`"', br'')
except (ImportError, AttributeError): except (ImportError, AttributeError):
return False return False
@check("xz", "xz compression utility") @check("xz", "xz compression utility")
def has_xz(): def has_xz():
# When Windows invokes a subprocess in shell mode, it uses `cmd.exe`, which # When Windows invokes a subprocess in shell mode, it uses `cmd.exe`, which