This is an archive of the discontinued Mercurial Phabricator instance.

upgrade: re-read current requirements after taking lock
ClosedPublic

Authored by pulkit on Jan 18 2021, 10:19 AM.

Details

Summary

Since we are writing to repository, it's better to re-read after taking the
lock.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jan 18 2021, 10:19 AM
pulkit updated this revision to Diff 25120.Jan 18 2021, 10:41 AM
marmoute accepted this revision.Jan 18 2021, 10:49 AM
marmoute added a subscriber: marmoute.

This looks "fine" as it fix the previous race window. However do not hesitate to follow up with another patch to reduce the code duplication.

pulkit updated this revision to Diff 25125.Jan 18 2021, 11:12 AM
marmoute accepted this revision.Jan 18 2021, 11:45 AM
mharbison72 accepted this revision.Jan 18 2021, 9:08 PM
This revision is now accepted and ready to land.Jan 18 2021, 9:08 PM
This revision was automatically updated to reflect the committed changes.