Page MenuHomePhabricator

share: move share safe functionality out of experimental
ClosedPublic

Authored by pulkit on Jan 18 2021, 10:19 AM.

Details

Summary

The share-safe functionality is complete and all configuration options are
implemented. The behavior is well discussed on mailing list and in reviews.

Let's unmark this as experimental to solve a chichen and egg issue.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Jan 18 2021, 10:19 AM
pulkit updated this revision to Diff 25119.Jan 18 2021, 10:20 AM
marmoute accepted this revision.Jan 18 2021, 10:54 AM
marmoute added a subscriber: marmoute.

This looks good. The documentation could be a bit better. However this can be dealt with during the freeze. So lets focus on the implementation/behavior side for now.

pulkit updated this revision to Diff 25128.Jan 18 2021, 11:12 AM
pulkit updated this revision to Diff 25130.Jan 18 2021, 11:35 AM
pulkit updated this revision to Diff 25131.Jan 18 2021, 11:53 AM
marmoute accepted this revision.Jan 18 2021, 11:55 AM
mharbison72 accepted this revision.Jan 18 2021, 9:08 PM
mharbison72 added a subscriber: mharbison72.

Queued with some minor copyediting, thanks

This revision is now accepted and ready to land.Jan 18 2021, 9:08 PM
This revision was automatically updated to reflect the committed changes.