This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9900

persistent-nodemap: add test case reproducing a Rust panic
ClosedPublic

Authored by SimonSapin on Jan 28 2021, 7:41 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3df00f905458: persistent-nodemap: add test case reproducing a Rust panic
Summary

Thanks to Mitchell Plamann for reporting this bug.
The next commit fixes it.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.Jan 28 2021, 7:41 AM
SimonSapin edited the summary of this revision. (Show Details)Jan 28 2021, 7:45 AM
Alphare accepted this revision.Jan 28 2021, 7:47 AM
Alphare added a subscriber: Alphare.

/!\ This patch and the next are meant for stable

pulkit accepted this revision.Jan 28 2021, 1:13 PM
This revision is now accepted and ready to land.Jan 28 2021, 1:13 PM

Revision Contents
Changeset List

PathPackages
Mtests/test-persistent-nodemap.t (9 lines)

Diff 25342

tests/test-persistent-nodemap.t

$ cat << EOF >> $HGRCPATH $ cat << EOF >> $HGRCPATH
> [storage] > [storage]
> # to avoid spamming the test > # to avoid spamming the test
> revlog.persistent-nodemap.slow-path=allow > revlog.persistent-nodemap.slow-path=allow
> EOF > EOF
#endif #endif
#if rust
Reported bug: some Rust code panics when handling the null revision
$ hg log -r 00000000 2>&1 | grep panicked
thread '<unnamed>' panicked at 'called `Option::unwrap()` on a `None` value', hg-cpython/src/revlog.rs:* (glob)
#endif
$ hg debugformat $ hg debugformat
format-variant repo format-variant repo
fncache: yes fncache: yes
dotencode: yes dotencode: yes
generaldelta: yes generaldelta: yes
share-safe: no share-safe: no
sparserevlog: yes sparserevlog: yes