This is an archive of the discontinued Mercurial Phabricator instance.

config: test priority involving alias and include
ClosedPublic

Authored by marmoute on Jan 29 2021, 8:39 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 29 2021, 8:39 PM
pulkit added a subscriber: pulkit.Jan 31 2021, 12:54 PM
pulkit added inline comments.
tests/test-config.t
428

Can we use consistent config values? It's not obvious that ui.logtemplate and command-templates.log are aliases or means same.

marmoute added inline comments.Jan 31 2021, 2:15 PM
tests/test-config.t
428

What do you mean by "consistent" ? I am using ui.logtemplate and command-templates.log because they are a simple existing alias. We could add a couple extra comment in the tests to make this clearer if you feel like this is needed.

pulkit added inline comments.Jan 31 2021, 2:51 PM
tests/test-config.t
428

TBH, I don't use this config and hence didn't know they are aliases.

Can we just use one of them or add a comment?

Or I am missing something and using config aliases is testing/will test something.

marmoute added inline comments.Feb 1 2021, 12:27 PM
tests/test-config.t
428

I am confused about your confusion…

pulkit added inline comments.Feb 2 2021, 1:41 PM
tests/test-config.t
428

Are we using both ui.logtemplate and command-templates.log to test something?

In other words, can our target test be achieved by just using one of them?

marmoute added inline comments.Feb 3 2021, 4:04 AM
tests/test-config.t
428

No, the whole point of the test is to check how value set for both ui.logtemplate and command-templates.log interact with each other, since they are alias for one another.

I will add a comment to clarify this.

The commend have been updated (the diff should get updated by heptapod CI soonish).

baymax updated this revision to Diff 25514.Feb 9 2021, 6:29 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 25571.Feb 11 2021, 1:46 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Feb 27 2021, 12:29 PM
This revision is now accepted and ready to land.Feb 27 2021, 12:29 PM
This revision was automatically updated to reflect the committed changes.