Page MenuHomePhabricator

config: use a new `alter` method in `fixconfig`
Needs ReviewPublic

Authored by marmoute on Fri, Jan 29, 8:39 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

The set function is doing various work related to metadata (eg: the source,
later the level). However the fixconfig call only updating some values
according to standard processing, not changing any of the related metadata. So
we introduce a new method and use it there.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Fri, Jan 29, 8:39 PM
Alphare added a subscriber: Alphare.Mon, Feb 8, 5:08 AM

I feel like the docstring is a bit short, maybe some of the commit message can find its way in there.

Alphare accepted this revision.Mon, Feb 8, 5:08 AM

... but it's not really reason enough to not accept it since the code is simple enough.

I updated the docstring a bit.

baymax updated this revision to Diff 25516.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Wed, Feb 10, 4:39 AM
baymax updated this revision to Diff 25573.Thu, Feb 11, 1:46 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)