This is an archive of the discontinued Mercurial Phabricator instance.

tests/test-config.t
448	I still have no idea what "higher level" means: is the highest level the systemwide config or is that lowest level? Perhaps "most-global" or "repo-local" instead of "higher level".

This revision now requires changes to proceed.Feb 2 2021, 11:50 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

This still requires changes to resolve my comments.

(Perhaps baymax could be altered to not refresh patches that are in "needs changes" state, since it clears that bit.)

This revision now requires changes to proceed.Feb 11 2021, 11:25 AM

In D9918#151222, @durin42 wrote:

This still requires changes to resolve my comments.

The series has received multiple comment update that should clarify your request. Can you recheck the series (and clarify your issue if you still have some?)

(Perhaps baymax could be altered to not refresh patches that are in "needs changes" state, since it clears that

In this case, the new version is expected to cover the requested change, so baymax behavior was right there.

I'm still confused here.

tests/test-config.t
451	I'm still confused by the "highest level (read later)" here - does this mean the command-templates version is higher, or the ui one is higher?

marmoute added inline comments.Feb 11 2021, 12:10 PM

tests/test-config.t
451	It depends on which one is the last be read. this (should) behave the same as if the file were setting the same value. Except each file set value for different, yet synonyms, config option. (cf initial report of the issue by Yuya a while back).

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Thanks for adding detailed comments.

marmoute added a commit: rHG377689cc295f: config: test priority involving alias.Feb 27 2021, 1:31 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG377689cc295f: config: test priority involving alias (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-config.t (25 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	25384		Jan 29 2021, 8:39 PM	★	★
Diff 2	25513		Feb 9 2021, 6:29 PM	★	★
Diff 3	25570		Feb 11 2021, 1:46 PM	★	★
Diff 4	25985	rHG377689cc295f09a2c5ed52563d39262a9590f56f	Jan 29 2021, 6:02 AM	★	★

Status	Author	Revision
Closed	marmoute	D9927 config: use level to properly deal with value priority
Closed	marmoute	D9926 config: track the "level" of a value
Closed	marmoute	D9925 config: track "source" along side value
Closed	marmoute	D9924 config: use a new `alter` method in `fixconfig`
Closed	marmoute	D9923 config: use the right API to access git-submodule
Closed	marmoute	D9922 config: use the right API to access template access
Closed	marmoute	D9921 config: use the right API to access subrepository section
Closed	marmoute	D9920 config: test priority involving alias and cli
Closed	marmoute	D9919 config: test priority involving alias and include
Closed	marmoute	D9918 config: test priority involving alias
Closed	marmoute	D9917 config: test priority involving the command line
Closed	marmoute	D9916 config: test priority involving include
Closed	marmoute	D9915 config: add a test for priority when includes are involved

Diff 25985

tests/test-config.t

	setup necessary file			setup necessary file

	$ cat > file-A.rc << EOF			$ cat > file-A.rc << EOF
	> [config-test]			> [config-test]
	> basic = value-A			> basic = value-A
	> pre-include= value-A			> pre-include= value-A
	> %include ./included.rc			> %include ./included.rc
	> post-include= value-A			> post-include= value-A
				> [command-templates]
				> log = "value-A\n"
	> EOF			> EOF

	$ cat > file-B.rc << EOF			$ cat > file-B.rc << EOF
	> [config-test]			> [config-test]
	> basic = value-B			> basic = value-B
				> [ui]
				> logtemplate = "value-B\n"
	> EOF			> EOF


	$ cat > included.rc << EOF			$ cat > included.rc << EOF
	> [config-test]			> [config-test]
	> pre-include= value-included			> pre-include= value-included
	> post-include= value-included			> post-include= value-included
	> EOF			> EOF
	$ HGRCPATH="file-A.rc" hg config config-test.post-include			$ HGRCPATH="file-A.rc" hg config config-test.post-include
	value-A			value-A

	command line override			command line override
	---------------------			---------------------

	$ HGRCPATH="file-A.rc:file-B.rc" hg config config-test.basic --config config-test.basic=value-CLI			$ HGRCPATH="file-A.rc:file-B.rc" hg config config-test.basic --config config-test.basic=value-CLI
	value-CLI			value-CLI

				Alias ordering
				--------------

				The official config is now `command-templates.log`, the historical
				pulkitUnsubmitted Not Done From higher level do you mean the file which is read later or some kind of levels in configs? pulkit: From higher level do you mean the file which is read later or some kind of levels in configs?
				marmouteAuthorUnsubmitted Done The file which is read the latest (actually, the value which is read the latest because include make this non-trivial). marmoute: The file which is read the latest (actually, the value which is read the latest because include…
				pulkitUnsubmitted Not Done Can you rephrase the comment then? I confused it with config aliases. pulkit: Can you rephrase the comment then? I confused it with config aliases.
				marmouteAuthorUnsubmitted Done I don't know what confuse you, so I am not sure what kind of rewriting we need. marmoute: I don't know what confuse you, so I am not sure what kind of rewriting we need.
				durin42Unsubmitted Not Done I still have no idea what "higher level" means: is the highest level the systemwide config or is that lowest level? Perhaps "most-global" or "repo-local" instead of "higher level". durin42: I still have no idea what "higher level" means: is the highest level the systemwide config or…
				`ui.logtemplate` is a valid alternative for it.

				When both are defined, The config value read the last "win", this should keep
				durin42Unsubmitted Not Done I'm still confused by the "highest level (read later)" here - does this mean the command-templates version is higher, or the ui one is higher? durin42: I'm still confused by the "highest level (read later)" here - does this mean the command…
				marmouteAuthorUnsubmitted Done It depends on which one is the last be read. this (should) behave the same as if the file were setting the same value. Except each file set value for different, yet synonyms, config option. (cf initial report of the issue by Yuya a while back). marmoute: It depends on which one is the last be read. this (should) behave the same as if the file were…
				being true if the config have other alias. In other word, the config value read
				earlier will be considered "lower level" and the config read later would be
				considered "higher level". And higher level values wins.

				BROKEN: currently not the case.

				$ HGRCPATH="file-A.rc" hg log -r .
				value-A
				$ HGRCPATH="file-B.rc" hg log -r .
				value-B
				$ HGRCPATH="file-A.rc:file-B.rc" hg log -r .
				value-A (known-bad-output !)
				value-B (missing-correct-output !)

This is an archive of the discontinued Mercurial Phabricator instance.

config: test priority involving aliasClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 25985

tests/test-config.t

config: test priority involving alias
ClosedPublic

Revision Contents
Changeset List