( )⚙ D10023 changegroup: use the local variable instead of reaching through self

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10023

changegroup: use the local variable instead of reaching through self
ClosedPublic

Authored by Alphare on Feb 19 2021, 6:15 AM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHG357d2ea95ce9: changegroup: use the local variable instead of reaching through self
Summary

Gratuitous cleanup while I was here.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Feb 19 2021, 6:15 AM
baymax updated this revision to Diff 25990.Mar 1 2021, 11:51 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute accepted this revision.Mar 2 2021, 1:45 PM
marmoute added a subscriber: marmoute.

We should be able to move this lower in the stack, right ?

pulkit accepted this revision.Mar 4 2021, 3:58 AM
This revision is now accepted and ready to land.Mar 4 2021, 3:58 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (2 lines)

Diff 25668

mercurial/changegroup.py

yield close yield close
self._verbosenote(_(b'%8.i (manifests)\n') % size) self._verbosenote(_(b'%8.i (manifests)\n') % size)
yield self._manifestsend yield self._manifestsend
mfdicts = None mfdicts = None
if self._ellipses and self._isshallow: if self._ellipses and self._isshallow:
mfdicts = [ mfdicts = [
(self._repo.manifestlog[n].read(), lr) (repo.manifestlog[n].read(), lr)
for (n, lr) in pycompat.iteritems(manifests) for (n, lr) in pycompat.iteritems(manifests)
] ]
manifests.clear() manifests.clear()
clrevs = {cl.rev(x) for x in clnodes} clrevs = {cl.rev(x) for x in clnodes}
it = self.generatefiles( it = self.generatefiles(
changedfiles, changedfiles,