( )⚙ D10024 error: add `hint` attribute to `SidedataHashError`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10024

error: add `hint` attribute to `SidedataHashError`
ClosedPublic

Authored by Alphare on Feb 19 2021, 6:15 AM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3941fe53670d: error: add `hint` attribute to `SidedataHashError`
Summary

This prevents an exception within an exception because hint does not exist.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Feb 19 2021, 6:15 AM
baymax updated this revision to Diff 25991.Mar 1 2021, 11:51 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute accepted this revision.Mar 2 2021, 1:46 PM
marmoute added a subscriber: marmoute.

Same feedback, this seems like a simple change set could happen sooner ?

pulkit accepted this revision.Mar 4 2021, 3:58 AM
This revision is now accepted and ready to land.Mar 4 2021, 3:58 AM
Alphare added a commit: rHG3941fe53670d: error: add `hint` attribute to `SidedataHashError`.Mar 4 2021, 7:38 AM
Closed by commit rHG3941fe53670d: error: add `hint` attribute to `SidedataHashError` (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/error.py (1 line)

Diff 25669

mercurial/error.py

class RevlogError(StorageError): class RevlogError(StorageError):
pass pass
class SidedataHashError(RevlogError): class SidedataHashError(RevlogError):
def __init__(self, key, expected, got): def __init__(self, key, expected, got):
self.hint = None
self.sidedatakey = key self.sidedatakey = key
self.expecteddigest = expected self.expecteddigest = expected
self.actualdigest = got self.actualdigest = got
class FilteredIndexError(IndexError): class FilteredIndexError(IndexError):
__bytes__ = _tobytes __bytes__ = _tobytes