( )⚙ D10102 rhg: Fall back to Python for bundle repositories

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10102

rhg: Fall back to Python for bundle repositories
ClosedPublic

Authored by SimonSapin on Mar 3 2021, 1:24 PM.

Details

Reviewers
Alphare
marmoute
Group Reviewers
hg-reviewers
Commits
rHGdfd35823635b: rhg: Fall back to Python for bundle repositories
Summary

rhg does not support bundles at all, yet.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

SimonSapin created this revision.Mar 3 2021, 1:24 PM
baymax updated this revision to Diff 26076.Mar 4 2021, 8:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Mar 5 2021, 4:02 AM
baymax updated this revision to Diff 26187.Mar 9 2021, 8:39 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute accepted this revision.Mar 9 2021, 1:06 PM
SimonSapin edited the summary of this revision. (Show Details)Mar 12 2021, 5:06 PM
SimonSapin updated this revision to Diff 26289.
SimonSapin added a commit: rHGdfd35823635b: rhg: Fall back to Python for bundle repositories.Mar 16 2021, 5:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGdfd35823635b: rhg: Fall back to Python for bundle repositories (authored by SimonSapin). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/repo.rs (2 lines)

Diff 26187

rust/hg-core/src/repo.rs

explicit_path: Option<&Path>, explicit_path: Option<&Path>,
) -> Result<Self, RepoError> { ) -> Result<Self, RepoError> {
if let Some(root) = explicit_path { if let Some(root) = explicit_path {
// Having an absolute path isn’t necessary here but can help code // Having an absolute path isn’t necessary here but can help code
// elsewhere // elsewhere
let absolute_root = current_dir()?.join(root); let absolute_root = current_dir()?.join(root);
if absolute_root.join(".hg").is_dir() { if absolute_root.join(".hg").is_dir() {
Self::new_at_path(absolute_root, config) Self::new_at_path(absolute_root, config)
} else if absolute_root.is_file() {
Err(HgError::unsupported("bundle repository").into())
} else { } else {
Err(RepoError::NotFound { Err(RepoError::NotFound {
at: root.to_owned(), at: root.to_owned(),
}) })
} }
} else { } else {
let current_directory = crate::utils::current_dir()?; let current_directory = crate::utils::current_dir()?;
// ancestors() is inclusive: it first yields `current_directory` // ancestors() is inclusive: it first yields `current_directory`