This is an archive of the discontinued Mercurial Phabricator instance.

tests: add a (very slow) test that executes pytype
ClosedPublic

Authored by mharbison72 on Mar 19 2021, 1:58 AM.

Download Raw Diff

Details

Reviewers

Alphare
pulkit

Group Reviewers

hg-reviewers

Commits

rHGe1d75c514ced: tests: add a (very slow) test that executes pytype

Summary

This is an updated form of D7295, and completes successfully with pytype
2021.03.22. The 5 or so crashes that were mostly in the hgweb files seems to
have been fixed in 2021.03.10.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Mar 19 2021, 1:58 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptMar 19 2021, 1:58 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

mharbison72 edited parent revisions, added: D10273: typing: disable processing of mercurial/upgrade_utils/actions.py; removed: D10236: commands: necessary annotations and assertions to pass pytype.Mar 25 2021, 8:10 PM

mharbison72 edited the summary of this revision. (Show Details)

mharbison72 added a child revision: D10274: typing: add type hints to mercurial/error.py.

mharbison72 updated this revision to Diff 26602.

Thanks for this. Hopefully it'll get easier when we remove Python 2, hopefully very soon.

pulkit accepted this revision.Apr 11 2021, 5:26 PM

This revision is now accepted and ready to land.Apr 11 2021, 5:26 PM

mharbison72 added a commit: rHGe1d75c514ced: tests: add a (very slow) test that executes pytype.Apr 11 2021, 7:24 PM

Closed by commit rHGe1d75c514ced: tests: add a (very slow) test that executes pytype (authored by mharbison72). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
A	M		tests/test-check-pytype.t (101 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	26512		Mar 19 2021, 1:58 AM	★	★
Diff 2	26602		Mar 25 2021, 8:10 PM	★	★
Diff 3	26810	rHGe1d75c514ceda28cced27fee948084f0279a4c93	Mar 19 2021, 12:36 AM	★	★

Commit	Parents	Author	Summary	Date
8427c01697da	395ec07d9a3b	Matt Harbison		Mar 19 2021, 12:36 AM

Status	Author	Revision
Closed	mharbison72	D10276 typing: make minor adjustments to mercurial/util.py to pass pytype checking
Closed	mharbison72	D10275 util: fix the signature for the pypy override of sortdict.update()
Closed	mharbison72	D10274 typing: add type hints to mercurial/error.py
Closed	mharbison72	D10237 tests: add a (very slow) test that executes pytype
Closed	mharbison72	D10273 typing: disable processing of mercurial/upgrade_utils/actions.py

Diff 26512

tests/test-check-pytype.t

This file was added.

				#require pytype py3 slow

				$ cd $RUNTESTDIR/..

				Many of the individual files that are excluded here confuse pytype
				because they do a mix of Python 2 and Python 3 things
				conditionally. There's no good way to help it out with that as far as
				I can tell, so let's just hide those files from it for now. We should
				endeavor to empty this list out over time, as some of these are
				probably hiding real problems.

				mercurial/bundlerepo.py # no vfs and ui attrs on bundlerepo
				mercurial/changegroup.py # mysterious incorrect type detection
				mercurial/chgserver.py # [attribute-error]
				mercurial/cmdutil.py # No attribute 'markcopied' on mercurial.context.filectx [attribute-error]
				mercurial/context.py # many [attribute-error]
				mercurial/copies.py # No attribute 'items' on None [attribute-error]
				mercurial/crecord.py # tons of [attribute-error], [module-attr]
				mercurial/debugcommands.py # [wrong-arg-types]
				mercurial/dispatch.py # initstdio: No attribute ... on TextIO [attribute-error]
				mercurial/exchange.py # [attribute-error]
				mercurial/hgweb/webcommands.py # [missing-parameter]
				mercurial/hgweb/wsgicgi.py # confused values in os.environ
				mercurial/httppeer.py # [attribute-error], [wrong-arg-types]
				mercurial/interfaces # No attribute 'capabilities' on peer [attribute-error]
				mercurial/keepalive.py # [attribute-error]
				mercurial/localrepo.py # [attribute-error]
				mercurial/lsprof.py # unguarded import
				mercurial/manifest.py # [unsupported-operands], [wrong-arg-types]
				mercurial/minirst.py # [unsupported-operands], [attribute-error]
				mercurial/patch.py # [wrong-arg-types]
				mercurial/pure/osutil.py # [invalid-typevar], [not-callable]
				mercurial/pure/parsers.py # [attribute-error]
				mercurial/pycompat.py # bytes vs str issues
				mercurial/repoview.py # [attribute-error]
				mercurial/sslutil.py # [attribute-error]
				mercurial/statprof.py # bytes vs str on TextIO.write() [wrong-arg-types]
				mercurial/testing/storage.py # tons of [attribute-error]
				mercurial/ui.py # [attribute-error], [wrong-arg-types]
				mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error]
				mercurial/upgrade.py # line 84, in upgraderepo: No attribute 'discard' on Dict[nothing, nothing] [attribute-error]
				mercurial/util.py # [attribute-error], [wrong-arg-count]
				mercurial/utils/procutil.py # [attribute-error], [module-attr], [bad-return-type]
				mercurial/utils/stringutil.py # [module-attr], [wrong-arg-count]
				mercurial/utils/memorytop.py # not 3.6 compatible
				mercurial/win32.py # [not-callable]
				mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]
				mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error]
				mercurial/wireprotov1peer.py # [attribute-error]
				mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs
				mercurial/wireprotov2server.py # [unsupported-operands], [attribute-error]

				TODO: use --no-cache on test server? Caching the files locally helps during
				development, but may be a hinderance for CI testing.

				$ pytype -V 3.6 --keep-going --jobs auto mercurial \
				> -x mercurial/bundlerepo.py \
				> -x mercurial/changegroup.py \
				> -x mercurial/chgserver.py \
				> -x mercurial/cmdutil.py \
				> -x mercurial/context.py \
				> -x mercurial/copies.py \
				> -x mercurial/crecord.py \
				> -x mercurial/debugcommands.py \
				> -x mercurial/dispatch.py \
				> -x mercurial/exchange.py \
				> -x mercurial/hgweb/wsgicgi.py \
				> -x mercurial/httppeer.py \
				> -x mercurial/interfaces \
				> -x mercurial/keepalive.py \
				> -x mercurial/localrepo.py \
				> -x mercurial/lsprof.py \
				> -x mercurial/manifest.py \
				> -x mercurial/minirst.py \
				> -x mercurial/patch.py \
				> -x mercurial/pure/osutil.py \
				> -x mercurial/pure/parsers.py \
				> -x mercurial/pycompat.py \
				> -x mercurial/repoview.py \
				> -x mercurial/sslutil.py \
				> -x mercurial/statprof.py \
				> -x mercurial/testing/storage.py \
				> -x mercurial/thirdparty \
				> -x mercurial/ui.py \
				> -x mercurial/unionrepo.py \
				> -x mercurial/upgrade.py \
				> -x mercurial/util.py \
				> -x mercurial/utils/procutil.py \
				> -x mercurial/utils/stringutil.py \
				> -x mercurial/utils/memorytop.py \
				> -x mercurial/hgweb/webcommands.py \
				> -x mercurial/win32.py \
				> -x mercurial/wireprotoframing.py \
				> -x mercurial/wireprotoserver.py \
				> -x mercurial/wireprotov1peer.py \
				> -x mercurial/wireprotov1server.py \
				> -x mercurial/wireprotov2server.py \
				> > $TESTTMP/pytype-output.txt \|\| cat $TESTTMP/pytype-output.txt

				Only show the results on a failure, because the output on success is also
				voluminous and variable.