Page MenuHomePhabricator

revlog-compression: use zstd by default (if available)
ClosedPublic

Authored by marmoute on Wed, Apr 7, 7:54 AM.

Details

Summary

As see in changeset bb271ec2fbfb, zstd is 20% to 50% faster for reading and
writing.

Use take advantage of the new config behavior to try zstd by default, falling
back to zlib is zstd is not available on that plateform.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Wed, Apr 7, 7:54 AM
baymax updated this revision to Diff 26678.Wed, Apr 7, 12:00 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 26682.Thu, Apr 8, 6:33 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Thu, Apr 8, 8:12 AM
Alphare added a subscriber: Alphare.

Funny how most of the examples in tests are actually larger in zstd. Not that it makes any difference, cool that this change is finally happening!

baymax updated this revision to Diff 26708.

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Thu, Apr 8, 12:49 PM
pulkit added a subscriber: pulkit.

I can't think of any reason against using zstd by default if it's available.

This revision is now accepted and ready to land.Thu, Apr 8, 12:49 PM
This revision was automatically updated to reflect the committed changes.