Page MenuHomePhabricator

revlog: update data file record before index rename
ClosedPublic

Authored by joerg.sonnenberger on May 17 2021, 10:26 PM.

Details

Summary

When migrating from inline to non-inline data storage, the data file is
recorded initially as zero sized so that it is removed on failure. But
the record has to be updated before the index is renamed, otherwise
data is lost on rollback.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

valentin.gatienbaron added inline comments.
tests/test-transaction-rollback-on-revlog-split.t
7–18

The change here in the next commit should probably be folded into this commit.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.