Page MenuHomePhabricator

revlog: fix index computation during inline->non-inline transition
ClosedPublic

Authored by joerg.sonnenberger on May 17 2021, 8:41 PM.

Details

Summary

The computation in 63edc384d3b7 failed to factor in the index entries
themselve as revlog.start() doesn't count them. Found by Valtenin
Gatienbaron with a more precise test case from me.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I knew zstd could be turned off, but I didn't knew there was an option to turn off even zlib. Cool.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

FYI, this change breaks the CI since the error code is not correct. I'll amend it.

https://foss.heptapod.net/octobus/mercurial-devel/-/jobs/198659