( )⚙ D10781 revlog: use `self.sidedata` directly to construct changelogrevision

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10781

revlog: use `self.sidedata` directly to construct changelogrevision
ClosedPublic

Authored by marmoute on May 28 2021, 6:56 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG659a452ee263: revlog: use `self.sidedata` directly to construct changelogrevision
Summary

We want to change revlog._revisiondata signature, so we need to migrate users
away.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.May 28 2021, 6:56 PM
Alphare accepted this revision as: Alphare.May 31 2021, 6:13 AM
baymax updated this revision to Diff 28294.May 31 2021, 6:37 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28391.Jun 1 2021, 11:10 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28440.Jun 4 2021, 9:54 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG659a452ee263: revlog: use `self.sidedata` directly to construct changelogrevision.Jun 7 2021, 5:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG659a452ee263: revlog: use `self.sidedata` directly to construct changelogrevision (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (11 lines)

Diff 28241

mercurial/changelog.py

- list of files - list of files
- commit message as a localstr - commit message as a localstr
- dict of extra metadata - dict of extra metadata
Unless you need to access all fields, consider calling Unless you need to access all fields, consider calling
``changelogrevision`` instead, as it is faster for partial object ``changelogrevision`` instead, as it is faster for partial object
access. access.
""" """
d, s = self._revisiondata(nodeorrev) d = self._revisiondata(nodeorrev)[0]
c = changelogrevision( sidedata = self.sidedata(nodeorrev)
self, d, s, self._copiesstorage == b'changeset-sidedata' copy_sd = self._copiesstorage == b'changeset-sidedata'
) c = changelogrevision(self, d, sidedata, copy_sd)
return (c.manifest, c.user, c.date, c.files, c.description, c.extra) return (c.manifest, c.user, c.date, c.files, c.description, c.extra)
def changelogrevision(self, nodeorrev): def changelogrevision(self, nodeorrev):
"""Obtain a ``changelogrevision`` for a node or revision.""" """Obtain a ``changelogrevision`` for a node or revision."""
text, sidedata = self._revisiondata(nodeorrev) text = self._revisiondata(nodeorrev)[0]
sidedata = self.sidedata(nodeorrev)
return changelogrevision( return changelogrevision(
self, text, sidedata, self._copiesstorage == b'changeset-sidedata' self, text, sidedata, self._copiesstorage == b'changeset-sidedata'
) )
def readfiles(self, nodeorrev): def readfiles(self, nodeorrev):
""" """
short version of read that only returns the files modified by the cset short version of read that only returns the files modified by the cset
""" """