( )⚙ D10796 revlog: use the `entry` function in bundlerepo

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10796

revlog: use the `entry` function in bundlerepo
ClosedPublic

Authored by marmoute on May 30 2021, 1:29 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG53289d02037a: revlog: use the `entry` function in bundlerepo
Summary

We can use some of the default value again!

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.May 30 2021, 1:29 PM
baymax updated this revision to Diff 28309.May 31 2021, 6:51 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision as: Alphare.May 31 2021, 10:43 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
mercurial/bundlerepo.py
97

this comment is possibly useless now?

baymax updated this revision to Diff 28324.May 31 2021, 4:21 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28406.Jun 1 2021, 11:17 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28421.Jun 2 2021, 7:43 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28455.Jun 4 2021, 11:05 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 28477.Jun 7 2021, 5:17 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG53289d02037a: revlog: use the `entry` function in bundlerepo.Jun 7 2021, 5:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG53289d02037a: revlog: use the `entry` function in bundlerepo (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundlerepo.py (22 lines)

Diff 28309

mercurial/bundlerepo.py

) )
if not self.index.has_node(deltabase): if not self.index.has_node(deltabase):
raise LookupError( raise LookupError(
deltabase, self.display_id, _(b'unknown delta base') deltabase, self.display_id, _(b'unknown delta base')
) )
baserev = self.rev(deltabase) baserev = self.rev(deltabase)
# start, size, full unc. size, base (unused), link, p1, p2, node, sidedata_offset (unused), sidedata_size (unused) # start, size, full unc. size, base (unused), link, p1, p2, node, sidedata_offset (unused), sidedata_size (unused)
AlphareUnsubmitted
Not Done

this comment is possibly useless now?

Alphare: this comment is possibly useless now?
e = ( e = revlogutils.entry(
revlogutils.offset_type(start, flags), flags=flags,
size, data_offset=start,
-1, data_compressed_length=size,
baserev, data_delta_base=baserev,
linkrev, link_rev=linkrev,
self.rev(p1), parent_rev_1=self.rev(p1),
self.rev(p2), parent_rev_2=self.rev(p2),
node, node_id=node,
0,
0,
revlog_constants.COMP_MODE_INLINE,
revlog_constants.COMP_MODE_INLINE,
) )
self.index.append(e) self.index.append(e)
self.bundlerevs.add(n) self.bundlerevs.add(n)
n += 1 n += 1
def _chunk(self, rev, df=None): def _chunk(self, rev, df=None):
# Warning: in case of bundle, the diff is against what we stored as # Warning: in case of bundle, the diff is against what we stored as
# delta base, not against rev - 1 # delta base, not against rev - 1