This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10846

transaction: simplify `undo.backupfiles` file creation with a variable
ClosedPublic

Authored by marmoute on Jun 9 2021, 10:37 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG88439c6fbafc: transaction: simplify `undo.backupfiles` file creation with a variable
Summary

This make the code shorter and clearer.

(This is an opportunity improvement while looking at something next to that.)

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/transaction.py (6 lines)

Diff 28523

mercurial/transaction.py

transaction is not explicitly committed before going out of transaction is not explicitly committed before going out of
scope)""" scope)"""
self._abort() self._abort()
def _writeundo(self): def _writeundo(self):
"""write transaction data for possible future undo call""" """write transaction data for possible future undo call"""
if self._undoname is None: if self._undoname is None:
return return
undobackupfile = self._opener.open(
b"%s.backupfiles" % self._undoname, b'w' undo_backup_path = b"%s.backupfiles" % self._undoname
) undobackupfile = self._opener.open(undo_backup_path, b'w')
undobackupfile.write(b'%d\n' % version) undobackupfile.write(b'%d\n' % version)
for l, f, b, c in self._backupentries: for l, f, b, c in self._backupentries:
if not f: # temporary file if not f: # temporary file
continue continue
if not b: if not b:
u = b'' u = b''
else: else:
if l not in self._vfsmap and c: if l not in self._vfsmap and c: