This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10848

createrepository: allow to directly pass the target requirements
ClosedPublic

Authored by marmoute on Jun 9 2021, 10:37 AM.

Details

Reviewers
pulkit
Alphare
Group Reviewers
hg-reviewers
Commits
rHGe43e68624dfb: createrepository: allow to directly pass the target requirements
Summary

This is useful when doing a local clone that copies store contents, it will
requires the destination to use the very same store requirements so directly
providing them will be simpler and safer

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jun 9 2021, 10:37 AM
pulkit accepted this revision.Jun 14 2021, 4:41 PM
This revision is now accepted and ready to land.Jun 14 2021, 4:41 PM
baymax updated this revision to Diff 28570.Jun 15 2021, 10:23 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Jun 16 2021, 3:48 AM
baymax updated this revision to Diff 28618.Jun 21 2021, 1:09 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (51 lines)

Diff 28648

mercurial/localrepo.py

b'sharedrelative', b'sharedrelative',
b'shareditems', b'shareditems',
b'shallowfilestore', b'shallowfilestore',
} }
return {k: v for k, v in createopts.items() if k not in known} return {k: v for k, v in createopts.items() if k not in known}
def createrepository(ui, path, createopts=None): def createrepository(ui, path, createopts=None, requirements=None):
"""Create a new repository in a vfs. """Create a new repository in a vfs.
``path`` path to the new repo's working directory. ``path`` path to the new repo's working directory.
``createopts`` options for the new repository. ``createopts`` options for the new repository.
``requirement`` predefined set of requirements.
(incompatible with ``createopts``)
The following keys for ``createopts`` are recognized: The following keys for ``createopts`` are recognized:
backend backend
The storage backend to use. The storage backend to use.
lfs lfs
Repository will be created with ``lfs`` requirement. The lfs extension Repository will be created with ``lfs`` requirement. The lfs extension
will automatically be loaded when the repository is accessed. will automatically be loaded when the repository is accessed.
narrowfiles narrowfiles
Set up repository to support narrow file storage. Set up repository to support narrow file storage.
sharedrepo sharedrepo
Repository object from which storage should be shared. Repository object from which storage should be shared.
sharedrelative sharedrelative
Boolean indicating if the path to the shared repo should be Boolean indicating if the path to the shared repo should be
stored as relative. By default, the pointer to the "parent" repo stored as relative. By default, the pointer to the "parent" repo
is stored as an absolute path. is stored as an absolute path.
shareditems shareditems
Set of items to share to the new repository (in addition to storage). Set of items to share to the new repository (in addition to storage).
shallowfilestore shallowfilestore
Indicates that storage for files should be shallow (not all ancestor Indicates that storage for files should be shallow (not all ancestor
revisions are known). revisions are known).
""" """
if requirements is not None:
if createopts is not None:
msg = b'cannot specify both createopts and requirements'
raise error.ProgrammingError(msg)
createopts = {}
else:
createopts = defaultcreateopts(ui, createopts=createopts) createopts = defaultcreateopts(ui, createopts=createopts)
unknownopts = filterknowncreateopts(ui, createopts) unknownopts = filterknowncreateopts(ui, createopts)
if not isinstance(unknownopts, dict): if not isinstance(unknownopts, dict):
raise error.ProgrammingError( raise error.ProgrammingError(
b'filterknowncreateopts() did not return a dict' b'filterknowncreateopts() did not return a dict'
) )
if unknownopts: if unknownopts:
raise error.Abort( raise error.Abort(
_( _(
b'unable to create repository because of unknown ' b'unable to create repository because of unknown '
b'creation option: %s' b'creation option: %s'
) )
% b', '.join(sorted(unknownopts)), % b', '.join(sorted(unknownopts)),
hint=_(b'is a required extension not loaded?'), hint=_(b'is a required extension not loaded?'),
) )
requirements = newreporequirements(ui, createopts=createopts) requirements = newreporequirements(ui, createopts=createopts)
requirements -= checkrequirementscompat(ui, requirements) requirements -= checkrequirementscompat(ui, requirements)
wdirvfs = vfsmod.vfs(path, expandpath=True, realpath=True) wdirvfs = vfsmod.vfs(path, expandpath=True, realpath=True)
hgvfs = vfsmod.vfs(wdirvfs.join(b'.hg')) hgvfs = vfsmod.vfs(wdirvfs.join(b'.hg'))
if hgvfs.exists(): if hgvfs.exists():
raise error.RepoError(_(b'repository %s already exists') % path) raise error.RepoError(_(b'repository %s already exists') % path)
if b'sharedrepo' in createopts: if b'sharedrepo' in createopts: