This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11076

dirstate: add dedicated function for updating data of a file
ClosedPublic

Authored by marmoute on Jul 11 2021, 7:38 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGa9d75262b992: dirstate: add dedicated function for updating data of a file
Summary

dirstate.normal() is too generic to be a user facing function for that. This
is a part of effort to refactor dirstate APIs and make them clearer.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 11 2021, 7:38 AM
Alphare accepted this revision.Jul 12 2021, 5:51 AM
Alphare added a subscriber: Alphare.
Alphare added inline comments.
mercurial/dirstate.py
600

s/calling/called/

This revision is now accepted and ready to land.Jul 12 2021, 5:51 AM
marmoute updated this revision to Diff 29207.Jul 12 2021, 5:56 AM
marmoute updated this revision to Diff 29208.Jul 12 2021, 9:45 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (8 lines)

Diff 29290

mercurial/dirstate.py

elif possibly_dirty: elif possibly_dirty:
self._addpath(filename, possibly_dirty=possibly_dirty) self._addpath(filename, possibly_dirty=possibly_dirty)
elif wc_tracked: elif wc_tracked:
self.normal(filename) self.normal(filename)
# XXX We need something for file that are dirty after an update # XXX We need something for file that are dirty after an update
else: else:
assert False, 'unreachable' assert False, 'unreachable'
@requires_parents_change
def update_parent_file_data(self, f, filedata):
"""update the information about the content of a file
This function should be called within a `dirstate.parentchange` context.
AlphareUnsubmitted
Not Done

s/calling/called/

Alphare: s/calling/called/
"""
self.normal(f, parentfiledata=filedata)
def _addpath( def _addpath(
self, self,
f, f,
mode=0, mode=0,
size=None, size=None,
mtime=None, mtime=None,
added=False, added=False,
merged=False, merged=False,