The dirstate file is large enough and the dirstatemap is quite insulated logic
already.
Details
Details
- Reviewers
SimonSapin Alphare pulkit - Group Reviewers
hg-reviewers - Commits
- rHG8b7e47802deb: dirstate: split dirstatemap in its own file
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
While we’re at it, instead of having a large class definition instead of if rustmod is not None: what do you think of having a separate rustdirstatemap.py file and conditionally importing one or the other?
Comment Actions
But actually not that simple because we have various extension and code that overwrite method of "the dirstatemap class" to reach their goal. So we would have to teach them about the duplication, etc.
So looks like a good idea, but too much of a detour for this series.
Comment Actions
This whole series looks good, I'll keep it around for one or two days to give others the chance to say something.