This is an archive of the discontinued Mercurial Phabricator instance.

dirstate: move the handling of special case within the dirstatemap
ClosedPublic

Authored by marmoute on Jul 4 2021, 5:50 PM.

Details

Summary

The dirstatemap is as well, if not better, suited to decided how to encode the
various case. So we move the associated code in the dirstatemap addfile
method.

This means the dirstate no longer need to know about the various magic value
used in the dirstate V1 format.

The pain of the messy API start to be quite palpable in Rust, we should clean
this up once the current large refactoring is dealt with.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 4 2021, 5:50 PM
SimonSapin accepted this revision.Jul 5 2021, 12:42 AM
pulkit accepted this revision.Jul 6 2021, 12:35 PM
This revision is now accepted and ready to land.Jul 6 2021, 12:35 PM
baymax updated this revision to Diff 28865.Jul 6 2021, 2:09 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)