This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11322

dirstatemap: conclude `reset_state` with logic using the new init
ClosedPublic

Authored by marmoute on Aug 21 2021, 5:56 AM.

Download Raw Diff

Details

Reviewers

Alphare

Group Reviewers

hg-reviewers

Commits

rHG4f0ebf83e4dc: dirstatemap: conclude `reset_state` with logic using the new __init__

Summary

Now the DirstateItem can deal with most of the logic related to its
initialization, our goal is to migrate the function to a more "unified" way were
minimal processing is done early before more generic code gets into play.

Nobody is calling this code yet, but this is about to change.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

marmoute created this revision.Aug 21 2021, 5:56 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptAug 21 2021, 5:56 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D11323: dirstatemap: use the default code to handle normal entry.Aug 21 2021, 5:56 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Aug 26 2021, 9:11 AM

This revision is now accepted and ready to land.Aug 26 2021, 9:11 AM

marmoute added a commit: rHG4f0ebf83e4dc: dirstatemap: conclude `reset_state` with logic using the new __init__.Aug 27 2021, 8:38 AM

Closed by commit rHG4f0ebf83e4dc: dirstatemap: conclude `reset_state` with logic using the new __init__ (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/dirstatemap.py (22 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	29971		Aug 21 2021, 5:56 AM	★	★
Diff 2	30048		Aug 26 2021, 9:00 AM	★	★
Diff 3	30090	rHG4f0ebf83e4dccb1d2fcc6bf608e01e3236ff302f	Jul 16 2021, 11:03 AM	★	★

Commit	Parents	Author	Summary	Date
70c9dd596e12	3b314a58d392	Pierre-Yves David		Jul 16 2021, 11:03 AM

Status	Author	Revision
Closed	marmoute	D11353 dirstate: drop the `_otherparent` method
Closed	marmoute	D11352 dirstate: drop the `_normal` method
Closed	marmoute	D11351 dirstate: drop the `_merge` method
Closed	marmoute	D11350 dirstate: drop the deprecated `drop` method
Closed	marmoute	D11349 dirstate: drop the deprecated `merge` method
Closed	marmoute	D11348 dirstate: drop the deprecated `remove` method
Closed	marmoute	D11347 dirstate: drop the deprecated `add` method
Closed	marmoute	D11346 dirstate: drop the deprecated `otherparent` method
Closed	marmoute	D11345 dirstate: drop the deprecated `normallookup` method
Closed	marmoute	D11344 dirstate: drop the deprecated `normal` method
Closed	marmoute	D11343 dirstate: also wrap the new method in `dirstatenonnormalcheck`
Closed	marmoute	D11332 dirstatemap: also discard item from sets
Closed	marmoute	D11331 dirstatemap: drop unused internal constant definition
Closed	marmoute	D11330 dirstate-item: add dedicated "legacy" constructor for `addfile` case
Closed	marmoute	D11329 dirstatemap: use the default code to handle "merged" case
Closed	marmoute	D11328 dirstatemap: use the default code to handle "added" case
Closed	marmoute	D11327 dirstatemap: use the default code to handle "removed" case
Closed	marmoute	D11326 dirstatemap: use the default code to handle "clean-p2" case
Closed	marmoute	D11325 dirstatemap: use the default code to handle "p2-tracked" case
Closed	marmoute	D11324 dirstatemap: use the default code to handle "possibly_dirty" case
Closed	marmoute	D11323 dirstatemap: use the default code to handle normal entry
Closed	marmoute	D11322 dirstatemap: conclude `reset_state` with logic using the new __init__
Closed	marmoute	D11321 dirstatemap: temporarily return early in `reset_state`
Closed	marmoute	D11320 dirstate-item: feed more information to `__init__`
Closed	marmoute	D11319 rust-dirstatemap: temporarily use `from_v1_data` in `addfile`
Closed	marmoute	D11318 dirstatemap: temporarily use `from_v1_data` in `addfile`
Closed	marmoute	D11317 dirstate-item: fix the declaration of the Cext `from_v1_meth`
Closed	marmoute	D11316 dirstate-item: fix Cext declaration of dm_nonnormal and dm_otherparent
Closed	marmoute	D11315 dirstatemap: replace `removefile` by an explicit `entry.set_untracked()`
Closed	marmoute	D11314 dirstate: forward `remove` call to newer `API`
Closed	marmoute	D11313 dirstate: directly call the dirstatemap in `set_untracked`

Diff 30048

mercurial/dirstatemap.py

	raise error.ProgrammingError(msg)			raise error.ProgrammingError(msg)
	mode, size, mtime = parentfiledata			mode, size, mtime = parentfiledata
	self.addfile(filename, mode=mode, size=size, mtime=mtime)			self.addfile(filename, mode=mode, size=size, mtime=mtime)
	self.nonnormalset.discard(filename)			self.nonnormalset.discard(filename)
	return			return
	else:			else:
	assert False, 'unreachable'			assert False, 'unreachable'

				old_entry = self._map.get(filename)
				self._dirs_incr(filename, old_entry)
				entry = DirstateItem(
				wc_tracked=wc_tracked,
				p1_tracked=p1_tracked,
				p2_tracked=p2_tracked,
				merged=merged,
				clean_p1=clean_p1,
				clean_p2=clean_p2,
				possibly_dirty=possibly_dirty,
				parentfiledata=parentfiledata,
				)
				if entry.dm_nonnormal:
				self.nonnormalset.add(filename)
				else:
				self.nonnormalset.discard(filename)
				if entry.dm_otherparent:
				self.otherparentset.add(filename)
				else:
				self.otherparentset.discard(filename)
				self._map[filename] = entry

	def set_untracked(self, f):			def set_untracked(self, f):
	"""Mark a file as no longer tracked in the dirstate map"""			"""Mark a file as no longer tracked in the dirstate map"""
	entry = self[f]			entry = self[f]
	self._dirs_decr(f, old_entry=entry, remove_variant=True)			self._dirs_decr(f, old_entry=entry, remove_variant=True)
	if entry.from_p2:			if entry.from_p2:
	self.otherparentset.add(f)			self.otherparentset.add(f)
	elif not entry.merged:			elif not entry.merged:
	self.copymap.pop(f, None)			self.copymap.pop(f, None)