This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	30117		Aug 27 2021, 10:49 AM	★	★
Diff 2	30139		Aug 30 2021, 8:59 AM	★	★
Diff 3	30153	rHGba9491be5e0c5aebe0f3165eb0e5d1648a94bd2a	Aug 26 2021, 10:39 AM	★	★

Commit	Parents	Author	Summary	Date
ed7a73d7389d	66ff8d3865b3	Pierre-Yves David		Aug 26 2021, 10:39 AM

Status	Author	Revision
Closed	marmoute	D11375 dirstate-item: implement `v1_mtime` with higher level block
Closed	marmoute	D11374 dirstate-item: implement `v1_size` with higher level block
Closed	marmoute	D11373 dirstate-item: implement v1_state with higher level block
Closed	marmoute	D11372 dirstate-item: add more logic to `from_p2`
Closed	marmoute	D11371 dirstate-item: implement `merged_removed` in a simpler way
Closed	marmoute	D11370 dirstate-item: implement `removed` in a simpler way
Closed	marmoute	D11369 dirstate-item: implement `from_p2_removed` in a simpler way
Closed	marmoute	D11368 dirstate-item: implement `from_p2` in a simpler way
Closed	marmoute	D11367 dirstate-item: implement `merged` in a simpler way
Closed	marmoute	D11366 dirstate-item: implement `added` in a simpler way
Closed	marmoute	D11365 dirstate-item: implement `tracked` in a simpler way
Closed	marmoute	D11364 dirstate-item: keep the full information in memory (for pure form)
Closed	marmoute	D11363 dirstate-item: have all the logic go through the v1_ accessors
Closed	marmoute	D11362 dirstate-item: drop the deprecated __getitem__ variante

Diff 30139

mercurial/cext/parsers.c

	return (PyObject *)t;			return (PyObject *)t;
	}			}

	static void dirstate_item_dealloc(PyObject *o)			static void dirstate_item_dealloc(PyObject *o)
	{			{
	PyObject_Del(o);			PyObject_Del(o);
	}			}

	static Py_ssize_t dirstate_item_length(PyObject *o)
	{
	return 4;
	}

	static PyObject dirstate_item_item(PyObject o, Py_ssize_t i)
	{
	dirstateItemObject t = (dirstateItemObject )o;
	switch (i) {
	case 0:
	return PyBytes_FromStringAndSize(&t->state, 1);
	case 1:
	return PyInt_FromLong(t->mode);
	case 2:
	return PyInt_FromLong(t->size);
	case 3:
	return PyInt_FromLong(t->mtime);
	default:
	PyErr_SetString(PyExc_IndexError, "index out of range");
	return NULL;
	}
	}

	static PySequenceMethods dirstate_item_sq = {
	dirstate_item_length, /* sq_length */
	0, /* sq_concat */
	0, /* sq_repeat */
	dirstate_item_item, /* sq_item */
	0, /* sq_ass_item */
	0, /* sq_contains */
	0, /* sq_inplace_concat */
	0 /* sq_inplace_repeat */
	};

	static PyObject dirstate_item_v1_state(dirstateItemObject self)			static PyObject dirstate_item_v1_state(dirstateItemObject self)
	{			{
	return PyBytes_FromStringAndSize(&self->state, 1);			return PyBytes_FromStringAndSize(&self->state, 1);
	};			};

	static PyObject dirstate_item_v1_mode(dirstateItemObject self)			static PyObject dirstate_item_v1_mode(dirstateItemObject self)
	{			{
	return PyInt_FromLong(self->mode);			return PyInt_FromLong(self->mode);
	0, /* tp_itemsize */			0, /* tp_itemsize */
	(destructor)dirstate_item_dealloc, /* tp_dealloc */			(destructor)dirstate_item_dealloc, /* tp_dealloc */
	0, /* tp_print */			0, /* tp_print */
	0, /* tp_getattr */			0, /* tp_getattr */
	0, /* tp_setattr */			0, /* tp_setattr */
	0, /* tp_compare */			0, /* tp_compare */
	0, /* tp_repr */			0, /* tp_repr */
	0, /* tp_as_number */			0, /* tp_as_number */
	&dirstate_item_sq, /* tp_as_sequence */			0, /* tp_as_sequence */
	0, /* tp_as_mapping */			0, /* tp_as_mapping */
	0, /* tp_hash */			0, /* tp_hash */
	0, /* tp_call */			0, /* tp_call */
	0, /* tp_str */			0, /* tp_str */
	0, /* tp_getattro */			0, /* tp_getattro */
	0, /* tp_setattro */			0, /* tp_setattro */
	0, /* tp_as_buffer */			0, /* tp_as_buffer */
	Py_TPFLAGS_DEFAULT, /* tp_flags */			Py_TPFLAGS_DEFAULT, /* tp_flags */

mercurial/pure/parsers.py

	size = NONNORMAL			size = NONNORMAL
	elif self.from_p2:			elif self.from_p2:
	size = FROM_P2			size = FROM_P2
	self._state = b'r'			self._state = b'r'
	self._mode = 0			self._mode = 0
	self._size = size			self._size = size
	self._mtime = 0			self._mtime = 0

	def __getitem__(self, idx):
	if idx == 0 or idx == -4:
	msg = b"do not use item[x], use item.state"
	util.nouideprecwarn(msg, b'6.0', stacklevel=2)
	return self._state
	elif idx == 1 or idx == -3:
	msg = b"do not use item[x], use item.mode"
	util.nouideprecwarn(msg, b'6.0', stacklevel=2)
	return self._mode
	elif idx == 2 or idx == -2:
	msg = b"do not use item[x], use item.size"
	util.nouideprecwarn(msg, b'6.0', stacklevel=2)
	return self._size
	elif idx == 3 or idx == -1:
	msg = b"do not use item[x], use item.mtime"
	util.nouideprecwarn(msg, b'6.0', stacklevel=2)
	return self._mtime
	else:
	raise IndexError(idx)

	@property			@property
	def mode(self):			def mode(self):
	return self._mode			return self._mode

	@property			@property
	def size(self):			def size(self):
	return self._size			return self._size

This is an archive of the discontinued Mercurial Phabricator instance.

dirstate-item: drop the deprecated __getitem__ varianteClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30139

mercurial/cext/parsers.c

mercurial/pure/parsers.py

dirstate-item: drop the deprecated getitem variante
ClosedPublic

Revision Contents
Changeset List