Page MenuHomePhabricator

dirstate-item: add more logic to `from_p2`
ClosedPublic

Authored by marmoute on Aug 27 2021, 1:11 PM.

Details

Summary

This seem semantically better even if this tracking case seems to always comes
with clean_p2 for now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 27 2021, 1:11 PM
Alphare accepted this revision.Aug 30 2021, 5:54 AM
Alphare added a subscriber: Alphare.

I was about to say something in the other patch about from_p2, good to see that we agree.

This revision is now accepted and ready to land.Aug 30 2021, 5:54 AM
baymax updated this revision to Diff 30149.Aug 30 2021, 9:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

This revision was automatically updated to reflect the committed changes.