Page MenuHomePhabricator

dirstate-item: keep the full information in memory (for pure form)
ClosedPublic

Authored by marmoute on Aug 27 2021, 10:49 AM.

Details

Summary

This changeset is finally reaching the area where we have been headed this whole
time. Since all implementation details are contained inside de DirstateItem
logic, we can change the way it is implemented.

So we store the information that are passed to the object and use them to
dynamically compute the "legacy" value.

For now we only do this for the Pure implementation, as this is a good
demonstration for the logic is fully insulated.

The next step will be the update the C code too, to implement the various method
with the new attribute (instead of the legacy one) and then start seriously
thinking about the parameters we feed into DirstateItem.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Aug 27 2021, 10:49 AM
Alphare accepted this revision.Aug 30 2021, 5:49 AM
This revision is now accepted and ready to land.Aug 30 2021, 5:49 AM
baymax updated this revision to Diff 30141.Aug 30 2021, 8:59 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)