( )⚙ D11365 dirstate-item: implement `tracked` in a simpler way

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11365

dirstate-item: implement `tracked` in a simpler way
ClosedPublic

Authored by marmoute on Aug 27 2021, 1:10 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGf1033c2d9b66: dirstate-item: implement `tracked` in a simpler way
Summary

We can simply use the underlying attribute.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Aug 27 2021, 1:10 PM
Alphare accepted this revision.Aug 30 2021, 5:50 AM
This revision is now accepted and ready to land.Aug 30 2021, 5:50 AM
baymax updated this revision to Diff 30142.Aug 30 2021, 8:59 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHGf1033c2d9b66: dirstate-item: implement `tracked` in a simpler way.Aug 30 2021, 9:05 AM
Closed by commit rHGf1033c2d9b66: dirstate-item: implement `tracked` in a simpler way (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/pure/parsers.py (2 lines)

Diff 30142

mercurial/pure/parsers.py

dirstatev1 format. It would make sense to ultimately deprecate it in dirstatev1 format. It would make sense to ultimately deprecate it in
favor of the more "semantic" attributes. favor of the more "semantic" attributes.
""" """
return self.v1_state() return self.v1_state()
@property @property
def tracked(self): def tracked(self):
"""True is the file is tracked in the working copy""" """True is the file is tracked in the working copy"""
return self.v1_state() in b"nma" return self._wc_tracked
@property @property
def added(self): def added(self):
"""True if the file has been added""" """True if the file has been added"""
return self.v1_state() == b'a' return self.v1_state() == b'a'
@property @property
def merged(self): def merged(self):