( )⚙ D11374 dirstate-item: implement `v1_size` with higher level block

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11374

dirstate-item: implement `v1_size` with higher level block
ClosedPublic

Authored by marmoute on Aug 27 2021, 1:11 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGdbf2d03850a2: dirstate-item: implement `v1_size` with higher level block
Summary

This is much easier to read and maintain.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Aug 27 2021, 1:11 PM
Alphare accepted this revision.Aug 30 2021, 5:56 AM
This revision is now accepted and ready to land.Aug 30 2021, 5:56 AM
baymax updated this revision to Diff 30151.Aug 30 2021, 9:00 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mmercurial/pure/parsers.py (32 lines)

Diff 30151

mercurial/pure/parsers.py

return self._mode if self._mode is not None else 0 return self._mode if self._mode is not None else 0
def v1_size(self): def v1_size(self):
"""return a "size" suitable for v1 serialization""" """return a "size" suitable for v1 serialization"""
if not (self._p1_tracked or self._p2_tracked or self._wc_tracked): if not (self._p1_tracked or self._p2_tracked or self._wc_tracked):
# the object has no state to record, this is -currently- # the object has no state to record, this is -currently-
# unsupported # unsupported
raise RuntimeError('untracked item') raise RuntimeError('untracked item')
elif not self._wc_tracked: elif self.merged_removed:
# File was deleted
if self._merged:
return NONNORMAL return NONNORMAL
elif self._clean_p2: elif self.from_p2_removed:
return FROM_P2 return FROM_P2
else: elif self.removed:
return 0 return 0
elif self._merged: elif self.merged:
return FROM_P2 return FROM_P2
elif not (self._p1_tracked or self._p2_tracked) and self._wc_tracked: elif self.added:
# Added
return NONNORMAL return NONNORMAL
elif self._clean_p2 and self._wc_tracked: elif self.from_p2:
return FROM_P2
elif not self._p1_tracked and self._p2_tracked and self._wc_tracked:
return FROM_P2 return FROM_P2
elif self._possibly_dirty: elif self._possibly_dirty:
if self._size is None: return self._size if self._size is not None else NONNORMAL
return NONNORMAL
else: else:
return self._size return self._size
elif self._wc_tracked:
return self._size
else:
raise RuntimeError('unreachable')
def v1_mtime(self): def v1_mtime(self):
"""return a "mtime" suitable for v1 serialization""" """return a "mtime" suitable for v1 serialization"""
if not (self._p1_tracked or self._p2_tracked or self._wc_tracked): if not (self._p1_tracked or self._p2_tracked or self._wc_tracked):
# the object has no state to record, this is -currently- # the object has no state to record, this is -currently-
# unsupported # unsupported
raise RuntimeError('untracked item') raise RuntimeError('untracked item')
elif not self._wc_tracked: elif not self._wc_tracked: