This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1141

repoview: add two new filternames to be used for accessing hidden commits
ClosedPublic

Authored by pulkit on Oct 17 2017, 8:19 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG308681291d11: repoview: add two new filternames to be used for accessing hidden commits
Summary

This patch adds two new filternames 'visible-hidden' and 'visible-warnhidden'
which will be used to access hidden commits.
'visible-hidden' will allow access of hidden commits with any warning. This will
be for read only commands.
'visible-warnhidden' will allow acces of hidden commits but will warn for that.
This will be for recoverable write commands.
For unrecoverable write commands, we don't need to have anything new as that's
the current behaviour.

We are using the same computehidden() function as we will be adding the hidden
revisions to pinnedrevs.

The idea to add new filternames is taken from directaccess extension from
fb-hgext.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 17 2017, 8:19 AM
dlax added a subscriber: dlax.Oct 17 2017, 3:09 PM
indygreg accepted this revision.Oct 18 2017, 12:12 PM
This revision is now accepted and ready to land.Oct 18 2017, 12:12 PM
Closed by commit rHG308681291d11: repoview: add two new filternames to be used for accessing hidden commits (authored by pulkit). · Explain WhyOct 18 2017, 12:22 PM
This revision was automatically updated to reflect the committed changes.
pulkit updated this revision to Diff 3203.Nov 2 2017, 2:05 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/branchmap.py (4 lines)
Mmercurial/repoview.py (2 lines)

Diff 3203

mercurial/branchmap.py

# Nearest subset of filter X is a filter Y so that: # Nearest subset of filter X is a filter Y so that:
# * Y is included in X, # * Y is included in X,
# * X - Y is as small as possible. # * X - Y is as small as possible.
# This create and ordering used for branchmap purpose. # This create and ordering used for branchmap purpose.
# the ordering may be partial # the ordering may be partial
subsettable = {None: 'visible', subsettable = {None: 'visible',
'visible': 'served', 'visible': 'served',
'served': 'immutable', 'served': 'immutable',
'immutable': 'base'} 'immutable': 'base',
'visible-warnhidden': 'visible',
'visible-hidden': 'visible'}
def updatecache(repo): def updatecache(repo):
cl = repo.changelog cl = repo.changelog
filtername = repo.filtername filtername = repo.filtername
partial = repo._branchcaches.get(filtername) partial = repo._branchcaches.get(filtername)
revs = [] revs = []
if partial is None or not partial.validfor(repo): if partial is None or not partial.validfor(repo):

mercurial/repoview.py

# function to compute filtered set # function to compute filtered set
# #
# When adding a new filter you MUST update the table at: # When adding a new filter you MUST update the table at:
# mercurial.branchmap.subsettable # mercurial.branchmap.subsettable
# Otherwise your filter will have to recompute all its branches cache # Otherwise your filter will have to recompute all its branches cache
# from scratch (very slow). # from scratch (very slow).
filtertable = {'visible': computehidden, filtertable = {'visible': computehidden,
'visible-warnhidden': computehidden,
'visible-hidden': computehidden,
'served': computeunserved, 'served': computeunserved,
'immutable': computemutable, 'immutable': computemutable,
'base': computeimpactable} 'base': computeimpactable}
def filterrevs(repo, filtername): def filterrevs(repo, filtername):
"""returns set of filtered revision for this filter name""" """returns set of filtered revision for this filter name"""
if filtername not in repo.filteredrevcache: if filtername not in repo.filteredrevcache:
func = filtertable[filtername] func = filtertable[filtername]