( )⚙ D1141 repoview: add two new filternames to be used for accessing hidden commits

This is an archive of the discontinued Mercurial Phabricator instance.

repoview: add two new filternames to be used for accessing hidden commits
ClosedPublic

Authored by pulkit on Oct 17 2017, 8:19 AM.

Details

Summary

This patch adds two new filternames 'visible-hidden' and 'visible-warnhidden'
which will be used to access hidden commits.
'visible-hidden' will allow access of hidden commits with any warning. This will
be for read only commands.
'visible-warnhidden' will allow acces of hidden commits but will warn for that.
This will be for recoverable write commands.
For unrecoverable write commands, we don't need to have anything new as that's
the current behaviour.

We are using the same computehidden() function as we will be adding the hidden
revisions to pinnedrevs.

The idea to add new filternames is taken from directaccess extension from
fb-hgext.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Oct 17 2017, 8:19 AM
dlax added a subscriber: dlax.Oct 17 2017, 3:09 PM
indygreg accepted this revision.Oct 18 2017, 12:12 PM
This revision is now accepted and ready to land.Oct 18 2017, 12:12 PM
This revision was automatically updated to reflect the committed changes.
pulkit updated this revision to Diff 3203.Nov 2 2017, 2:05 PM