This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1142

dispatch: filter the repository depending on func.cmdtype
ClosedPublic

Authored by pulkit on Oct 17 2017, 8:19 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGc94adbe97ae4: dispatch: filter the repository depending on func.cmdtype
Summary

This patch adds support for filtering the repository on the basis of
func.cmdtype. After this patch, repo.filtername will be used to decide what
level of access the running command can has on hidden commits.

All this logic is behind a config flag experimental.directacess which defaults
to False.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 17 2017, 8:19 AM
dlax added a subscriber: dlax.Oct 17 2017, 3:09 PM
indygreg accepted this revision.Oct 18 2017, 12:17 PM
indygreg added a subscriber: indygreg.

Seems reasonable as an experimental feature.

This revision is now accepted and ready to land.Oct 18 2017, 12:17 PM
Closed by commit rHGc94adbe97ae4: dispatch: filter the repository depending on func.cmdtype (authored by pulkit). · Explain WhyOct 18 2017, 12:22 PM
This revision was automatically updated to reflect the committed changes.
pulkit updated this revision to Diff 3204.Nov 2 2017, 2:05 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/configitems.py (3 lines)
Mmercurial/dispatch.py (10 lines)

Diff 3204

mercurial/configitems.py

default=100, default=100,
) )
coreconfigitem('experimental', 'copytrace.sourcecommitlimit', coreconfigitem('experimental', 'copytrace.sourcecommitlimit',
default=100, default=100,
) )
coreconfigitem('experimental', 'crecordtest', coreconfigitem('experimental', 'crecordtest',
default=None, default=None,
) )
coreconfigitem('experimental', 'directaccess',
default=False,
)
coreconfigitem('experimental', 'editortmpinhg', coreconfigitem('experimental', 'editortmpinhg',
default=False, default=False,
) )
coreconfigitem('experimental', 'evolution', coreconfigitem('experimental', 'evolution',
default=list, default=list,
) )
coreconfigitem('experimental', 'evolution.allowdivergence', coreconfigitem('experimental', 'evolution.allowdivergence',
default=False, default=False,

mercurial/dispatch.py

pycompat, pycompat,
registrar, registrar,
scmutil, scmutil,
ui as uimod, ui as uimod,
util, util,
) )
unrecoverablewrite = registrar.command.unrecoverablewrite unrecoverablewrite = registrar.command.unrecoverablewrite
recoverablewrite = registrar.command.recoverablewrite
readonly = registrar.command.readonly
class request(object): class request(object):
def __init__(self, args, ui=None, repo=None, fin=None, fout=None, def __init__(self, args, ui=None, repo=None, fin=None, fout=None,
ferr=None, prereposetups=None): ferr=None, prereposetups=None):
self.args = args self.args = args
self.ui = ui self.ui = ui
self.repo = repo self.repo = repo
raise error.RepoError(_("no repository found in" raise error.RepoError(_("no repository found in"
" '%s' (.hg not found)") " '%s' (.hg not found)")
% pycompat.getcwd()) % pycompat.getcwd())
raise raise
if repo: if repo:
ui = repo.ui ui = repo.ui
if options['hidden']: if options['hidden']:
repo = repo.unfiltered() repo = repo.unfiltered()
# Accessing hidden commits based on func.cmdtype
if lui.configbool('experimental', 'directaccess'):
if func.cmdtype == readonly:
repo = repo.filtered('visible-hidden')
elif func.cmdtype == recoverablewrite:
repo = repo.filtered('visible-warnhidden')
args.insert(0, repo) args.insert(0, repo)
elif rpath: elif rpath:
ui.warn(_("warning: --repository ignored\n")) ui.warn(_("warning: --repository ignored\n"))
msg = _formatargs(fullargs) msg = _formatargs(fullargs)
ui.log("command", '%s\n', msg) ui.log("command", '%s\n', msg)
strcmdopt = pycompat.strkwargs(cmdoptions) strcmdopt = pycompat.strkwargs(cmdoptions)
d = lambda: util.checksignature(func)(ui, *args, **strcmdopt) d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)