Page MenuHomePhabricator

config: gather allowdivergence under the evolution namespace

Authored by lothiraldan on Oct 17 2017, 11:04 AM.



Grouping all evolution related-config under the experimental.evolution
namespace would helps the future migration outside [experimental].

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lothiraldan created this revision.Oct 17 2017, 11:04 AM

I think this series overall cleans up the namespaces. I don't really love that evolution is still "hiding" under experimental but currently we don't have a way of marking non-"experimental" configs as experimental still so I guess this will have to suffice for now. I'll take a closer look tomorrow if nobody else gets to this first.

quark added a subscriber: quark.Oct 17 2017, 6:51 PM

I'm not a big fan of inserting evolution everywhere. It confuses people. I'd prefer things like experimental.obsstore=bool.

indygreg accepted this revision.Oct 18 2017, 12:05 PM
indygreg added a subscriber: indygreg.

@quark raises a valid point. The good thing is this is all under [experimental] which means there are no BC concerns. I'm all for bikeshedding a better naming strategy when things are marked as non-experimental. Until then, it isn't worth our time IMO.

This revision is now accepted and ready to land.Oct 18 2017, 12:05 PM
This revision was automatically updated to reflect the committed changes.